Optional package papilo (dependency of scip) #34726

mkoeppe · 2022-11-05T22:00:13Z

https://github.com/scipopt/papilo/archive/refs/tags/v2.1.1.tar.gz

Not packaged anywhere - https://repology.org/projects/?search=papilo

scip uses papilo's header-only library, but papilo also likes to build an executable that may depend on scip and other solvers at compile time. - scipopt/papilo#21

New packages needed as dependencies:

https://github.com/oneapi-src/oneTBB - https://repology.org/project/onetbb/versions

CC: @dimpase

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: 4b71c4a

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34726

The text was updated successfully, but these errors were encountered:

mkoeppe · 2022-11-05T23:35:59Z

Branch: u/mkoeppe/optional_package_papilo__dependency_of_scip_

sagetrac-git · 2022-11-05T23:43:17Z

Commit: 0dfa4b9

sagetrac-git · 2022-11-05T23:43:17Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`0dfa4b9`	`build/pkgs/papilo: New`

mkoeppe · 2022-11-06T00:03:56Z

comment:5

tox -e docker-ubuntu-jammy-standard -- papilo gives

  [papilo-2.1.1]   CMake Error at /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake:141 (find_package):
  [papilo-2.1.1]     Could not find a package configuration file provided by
  [papilo-2.1.1]     "boost_program_options" (requested version 1.74.0) with any of the
  [papilo-2.1.1]     following names:
  [papilo-2.1.1]   
  [papilo-2.1.1]       boost_program_optionsConfig.cmake
  [papilo-2.1.1]       boost_program_options-config.cmake
  [papilo-2.1.1]   
  [papilo-2.1.1]     Add the installation prefix of "boost_program_options" to CMAKE_PREFIX_PATH
  [papilo-2.1.1]     or set "boost_program_options_DIR" to a directory containing one of the
  [papilo-2.1.1]     above files.  If "boost_program_options" provides a separate development
  [papilo-2.1.1]     package or SDK, be sure it has been installed.
  [papilo-2.1.1]   Call Stack (most recent call first):
  [papilo-2.1.1]     /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake:258 (boost_find_component)
  [papilo-2.1.1]     /usr/share/cmake-3.22/Modules/FindBoost.cmake:594 (find_package)
  [papilo-2.1.1]     CMakeLists.txt:50 (find_package)

https://stackoverflow.com/questions/20502194/cmake-cannot-find-boost-program-options-on-debian

sagetrac-git · 2022-11-06T00:36:22Z

Branch pushed to git repo; I updated commit sha1. New commits:

`088b11a`	`build/pkgs/boost_cropped/distros/debian.txt: Add libboost-program-options-dev`

sagetrac-git · 2022-11-06T00:36:22Z

Changed commit from 0dfa4b9 to 088b11a

mkoeppe · 2022-11-06T00:37:13Z

comment:7

[papilo-2.1.1] -- Could NOT find TBB (missing: TBB_DIR)
[papilo-2.1.1] -- Could NOT find TBB (missing: TBB_IMPORTED_TARGETS tbb tbbmalloc) (Required is at least version "2018")
[papilo-2.1.1] -- Downloading TBB

so we'll need to add tbb as a package

sagetrac-git · 2022-11-10T01:19:37Z

Branch pushed to git repo; I updated commit sha1. New commits:

`adb37b8`	`build/pkgs/papilo: Add dependency onetbb`

sagetrac-git · 2022-11-10T01:19:37Z

Changed commit from 088b11a to adb37b8

sagetrac-git · 2022-11-10T01:30:05Z

Changed commit from adb37b8 to 36abfb5

sagetrac-git · 2022-11-10T01:30:05Z

Branch pushed to git repo; I updated commit sha1. New commits:

`36abfb5`	`build/pkgs/onetbb: New`

sagetrac-git · 2022-11-10T02:14:29Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`b1e6d07`	`build/pkgs/onetbb: New`

sagetrac-git · 2022-11-10T02:14:29Z

Changed commit from 36abfb5 to b1e6d07

mkoeppe · 2022-11-13T19:31:20Z

Author: Matthias Koeppe

sagetrac-git · 2022-11-14T06:30:32Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b56f82a`	`build/pkgs/onetbb/spkg-install.in: Do not treat compiler warnings as errors`

sagetrac-git · 2022-11-14T06:30:32Z

Changed commit from b1e6d07 to b56f82a

mkoeppe · 2022-11-14T07:51:38Z

comment:14

Our boost_cropped package does not provide program_options.
ubuntu-bionic-minimal: https://github.com/mkoeppe/PySCIPOpt/actions/runs/3457453303/jobs/5774142273

[papilo-2.1.1]   CMake Error at /sage/local/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  [papilo-2.1.1]     Could NOT find Boost (missing: program_options) (found suitable version
  [papilo-2.1.1]     "1.66.0", minimum required is "1.65")

dimpase · 2022-11-14T11:01:56Z

comment:15

could it be due to out boost being over 5 years old? I'll check if we can update to 1.80 easily

dimpase · 2022-11-14T11:10:24Z

comment:16

see #34748 for boost update

dimpase · 2022-11-14T11:54:44Z

Dependencies: #34748

dimpase · 2022-11-14T11:54:44Z

comment:17

use updated boost_cropped

dimpase · 2022-11-14T14:08:29Z

Reviewer: Dima Pasechnik

mkoeppe · 2022-11-20T09:25:31Z

comment:30

build failure on fedora-37 - scipopt/papilo#23

mkoeppe · 2022-11-23T22:08:33Z

comment:31

build failure of onetbb on ubuntu-trusty-toolchain-gcc_9 https://github.com/mkoeppe/PySCIPOpt/actions/runs/3535481134/jobs/5933596249

2021.7.0/src/src/tbb/../../include/tbb/../oneapi/tbb/detail/_concurrent_skip_list.h:25,
                 from /sage/local/var/tmp/sage/build/onetbb-2021.7.0/src/src/tbb/../../include/tbb/../oneapi/tbb/concurrent_map.h:21,
                 from /sage/local/var/tmp/sage/build/onetbb-2021.7.0/src/src/tbb/../../include/tbb/concurrent_map.h:17,
                 from /sage/local/var/tmp/sage/build/onetbb-2021.7.0/src/test/tbb/test_concurrent_map.cpp:19:
/usr/include/c++/9/bits/basic_string.h: In instantiation of 'class std::basic_string<char, std::char_traits<char>, tbb::detail::d1::tbb_allocator<char> >':
/sage/local/var/tmp/sage/build/onetbb-2021.7.0/src/test/common/concurrent_associative_common.h:964:29:   required from 'void test_map_specific_types() [with Checker = OrderedMapTypesTester]'
/sage/local/var/tmp/sage/build/onetbb-2021.7.0/src/test/tbb/test_concurrent_map.cpp:90:52:   required from here
/usr/include/c++/9/bits/basic_string.h:3146:63: error: no class template named 'rebind' in 'class tbb::detail::d1::tbb_allocator<char>'
 3146 |       typedef typename _Alloc::template rebind<_CharT>::other _CharT_alloc_type;
      |                                                               ^~~~~~~~~~~~~~~~~
compilation terminated due to -Wfatal-errors.
make[5]: *** [test/CMakeFiles/test_concurrent_map.dir/tbb/test_concurrent_map.cpp.o] Error 1
make[5]: Target `test/CMakeFiles/test_concurrent_map.dir/build' not remade because of errors.
make[4]: *** [test/CMakeFiles/test_concurrent_map.dir/all] Error 2

mkoeppe · 2022-11-23T22:10:55Z

comment:32

That's oneapi-src/oneTBB#383

sagetrac-git · 2022-11-27T00:19:30Z

Changed commit from a52e72f to 3adc477

sagetrac-git · 2022-11-27T00:19:30Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1f30f5c`	`Merge tag '9.8.beta4' into t/34726/optional_package_papilo__dependency_of_scip_`
`b62841d`	`build/pkgs/papilo/dependencies: Add gfortran`
`6e78b57`	`build/pkgs/papilo/spkg-install.in: Set BOOST_ROOT`
`3adc477`	`build/pkgs/onetbb/spkg-configure.m4: New`

mkoeppe · 2022-11-27T00:22:51Z

comment:34

build failures on ubuntu-trusty-toolchain-gcc_9 (comment:31) and fedora-37 (comment:30) remain, but that should not stop us from merging these optional packages. Both need help from upstream

sagetrac-git · 2022-11-27T23:12:29Z

Branch pushed to git repo; I updated commit sha1. New commits:

`45f957e`	`Revert "build/pkgs/boost_cropped/distros/debian.txt: Add libboost-program-options-dev"`

sagetrac-git · 2022-11-27T23:12:29Z

Changed commit from 3adc477 to 45f957e

sagetrac-git · 2022-12-09T02:32:58Z

Changed commit from 45f957e to d26090f

sagetrac-git · 2022-12-09T02:32:58Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ebac2fd`	`build/pkgs/papilo/patches: Add https://github.com/scipopt/papilo/commit/e34cfbe0b6d6b4c6e8d5d9305046a00821c81828`
`d26090f`	`build/pkgs/papilo/patches/import_memory_multiprecision.patch: New, back out ineffective patch`

mkoeppe · 2022-12-09T02:37:31Z

comment:37

This fixed the build failure on fedora-37.

mkoeppe · 2022-12-09T17:55:16Z

comment:38

Ready for review

sagetrac-git · 2022-12-09T21:33:26Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4b71c4a`	`build/pkgs/onetbb/distros/conda.txt: New`

sagetrac-git · 2022-12-09T21:33:26Z

Changed commit from d26090f to 4b71c4a

mkoeppe · 2022-12-11T20:51:35Z

comment:41

Thanks!

vbraun · 2023-01-01T23:43:36Z

Changed branch from u/mkoeppe/optional_package_papilo__dependency_of_scip_ to 4b71c4a

… cmake version to 3.11 scip (sagemath#31329) fails to build with the older cmake provided by ubuntu- xenial (scipopt/scip#32) papilo (sagemath#34726) needs at least cmake 3.11. 3.10.x is shipped on ubuntu-bionic, linuxmint-19. URL: https://trac.sagemath.org/34746 Reported by: mkoeppe Ticket author(s): Matthias Koeppe Reviewer(s): Dima Pasechnik

mkoeppe added this to the sage-9.8 milestone Nov 5, 2022

mkoeppe added c: packages: optional labels Nov 5, 2022

This comment has been minimized.

Sign in to view

mkoeppe added the s: needs review label Nov 13, 2022

mkoeppe added s: needs review and removed s: needs work labels Nov 27, 2022

dimpase added s: positive review and removed s: needs review labels Dec 11, 2022

vbraun removed the s: positive review label Jan 1, 2023

vbraun closed this as completed in f84915f Jan 1, 2023

dimpase mentioned this issue Dec 31, 2022

update boost-cropped to 1.82.0 #34748

Open

kryzar pushed a commit to kryzar/sage that referenced this issue Feb 6, 2023

Merge sagemath#34726

76667d4

kryzar pushed a commit to kryzar/sage that referenced this issue Feb 6, 2023

Merge sagemath#34726

931e348

kryzar pushed a commit to kryzar/sage that referenced this issue Feb 6, 2023

Merge sagemath#34726

805e67d

Optional package papilo (dependency of scip) #34726

Optional package papilo (dependency of scip) #34726

Comments

mkoeppe commented Nov 5, 2022

This comment has been minimized.

This comment has been minimized.

mkoeppe commented Nov 5, 2022

sagetrac-git mannequin commented Nov 5, 2022

sagetrac-git mannequin commented Nov 5, 2022

mkoeppe commented Nov 6, 2022

sagetrac-git mannequin commented Nov 6, 2022

sagetrac-git mannequin commented Nov 6, 2022

mkoeppe commented Nov 6, 2022

This comment has been minimized.

sagetrac-git mannequin commented Nov 10, 2022

sagetrac-git mannequin commented Nov 10, 2022

sagetrac-git mannequin commented Nov 10, 2022

sagetrac-git mannequin commented Nov 10, 2022

sagetrac-git mannequin commented Nov 10, 2022

sagetrac-git mannequin commented Nov 10, 2022

mkoeppe commented Nov 13, 2022

sagetrac-git mannequin commented Nov 14, 2022

sagetrac-git mannequin commented Nov 14, 2022

mkoeppe commented Nov 14, 2022

dimpase commented Nov 14, 2022

dimpase commented Nov 14, 2022

dimpase commented Nov 14, 2022

dimpase commented Nov 14, 2022

dimpase commented Nov 14, 2022

mkoeppe commented Nov 20, 2022

mkoeppe commented Nov 23, 2022

mkoeppe commented Nov 23, 2022

sagetrac-git mannequin commented Nov 27, 2022

sagetrac-git mannequin commented Nov 27, 2022

mkoeppe commented Nov 27, 2022

sagetrac-git mannequin commented Nov 27, 2022

sagetrac-git mannequin commented Nov 27, 2022

sagetrac-git mannequin commented Dec 9, 2022

sagetrac-git mannequin commented Dec 9, 2022

mkoeppe commented Dec 9, 2022

mkoeppe commented Dec 9, 2022

sagetrac-git mannequin commented Dec 9, 2022

sagetrac-git mannequin commented Dec 9, 2022

mkoeppe commented Dec 11, 2022

vbraun commented Jan 1, 2023