Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Actions: Remove pull_request triggers for portability workflows #34942

Closed
mkoeppe opened this issue Jan 27, 2023 · 15 comments
Closed

GH Actions: Remove pull_request triggers for portability workflows #34942

mkoeppe opened this issue Jan 27, 2023 · 15 comments
Labels
c: porting p: critical / 2 t: enhancement
Milestone
sage-9.8

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jan 27, 2023

The portability tests cannot be run on every PR.

Instead we need to run build, doc-build on every PR (just as we already run lint)

We also remove the ticket workflow; it is not needed.

Fixes sagemath/trac-to-github#157

CC: @tobiasdiez

Component: porting

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/gh_actions__remove_pull_request_triggers_for_portability_workflows @ 59033e2

Reviewer: Tobias Diez

Issue created by migration from https://trac.sagemath.org/ticket/34942
@mkoeppe mkoeppe added this to the sage-9.8 milestone Jan 27, 2023
@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 27, 2023

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 27, 2023

Branch: u/mkoeppe/gh_actions__remove_pull_request_triggers_for_portability_workflows

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 27, 2023

Commit: 2958f16

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 27, 2023

New commits:

2958f16.github/workflows: Run build, doc-build on pull_request; do not run portability on pull_request; remove ticket.yaml

@mkoeppe

This comment has been minimized.

Sign in to view
@tobiasdiez
Copy link
Contributor

comment:5

From https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

By default, a workflow only runs when a pull_request event's activity type is opened, synchronize, or reopened.

So I think, simply having the trigger as "pull_request" should be sufficient, or not?

@tobiasdiez
Copy link
Contributor

comment:6

In the docs workflow, "if: github.repository == 'sagemath/sagetrac-mirror'" needs to be removed as well.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 27, 2023

comment:7

Replying to Tobias Diez:

simply having the trigger as "pull_request" should be sufficient, or not?

You are right; I'll simplify it.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 27, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

adf85df.github/workflows/{build,doc-build}.yml: Use default event types for pull_request trigger
59033e2.github/workflows/doc-build.yml: Remove check for repo sagemath/sagetrac-mirror; deploy when NETLIFY_AUTH_TOKEN is set

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 27, 2023

Changed commit from 2958f16 to 59033e2

@tobiasdiez
Copy link
Contributor

comment:9

Looks good!

@tobiasdiez
Copy link
Contributor

Reviewer: Tobias Diez

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 28, 2023

comment:10

Thanks!

@mkoeppe

This comment has been minimized.

Sign in to view
mkoeppe pushed a commit that referenced this issue Feb 6, 2023
Trac #34942: GH Actions: Remove pull_request triggers for portability…
2d3c71b 
… workflows

The portability tests cannot be run on every PR.

Instead we need to run `build`, `doc-build` on every PR (just as we
already run `lint`)

We also remove the `ticket` workflow; it is not needed.

Fixes sagemath/trac-to-github#157

URL: https://trac.sagemath.org/34942
Reported by: mkoeppe
Ticket author(s): Matthias Koeppe
Reviewer(s): Tobias Diez
@tobiasdiez
Copy link
Contributor

This can be closed now.

@mkoeppe mkoeppe mentioned this issue Feb 13, 2023
Merged
4 tasks
vbraun pushed a commit that referenced this issue May 22, 2023
gh-35108: src/doc/en/developer/portability_testing.rst: Update after …
8b24c20 
…migration

    
…to GitHub (no more sagetrac-mirror)

<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
We update the documentation on portability testing.
- Instead of referring to trac and sagetrac-mirror, we direct users to
use their personal fork
- We remove the description of a method using pull requests because
#34942 disabled it
- We update according to changed defaults on GH Actions.
<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->

Test running at:
https://github.com/mkoeppe/sage/actions/runs/4911075567/jobs/8768884045
(the "standard", "minimal" etc. jobs without "-pre" should now work).
    
URL: #35108
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik, Matthias Köppe, Tobias Diez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: porting p: critical / 2 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@kwankyu @tobiasdiez @mkoeppe