Longer slider and labels on sliders

[itolkov]

Slider update:

• Sliders are now version 3, which is similar to current version 1, but longer

• Label to the right of slider containing the current slider value (string representation), which is updated dynamically

• User can hide label with "display_value=False".

Component: notebook

Issue created by migration from https://trac.sagemath.org/ticket/3599

[itolkov]

Attachment: trac3599_sage_1.patch.gz

Attachment: trac3599_extcode_1.patch.gz

[jasongrout]

comment:4

Where does the png file go?

[jasongrout]

comment:5

Answering my question, it goes in:

$SAGE_ROOT/data/extcode/notebook/javascript/jqueryui/themes/flora/i/slider-bg-3.png

This patch seems to do what it claims and looks like reasonable code, looks nice, and doctests pass in sage/server/notebook/*.py

+1

[williamstein]

the image of the slider

[williamstein]

comment:6

Attachment: trac3599_extcode_2.patch.gz

I replaced the png by a proper patch.

[williamstein]

comment:7

I give this another positive review, by the way. Very good.

[sagetrac-mabshoff]

comment:8

Merged trac3599_sage_1.patch and trac3599_extcode_1.patch in Sage 3.1.alpha0. trac3599_extcode_2.patch is empty. You need to add a git style patch or reattach the png.

Cheers,

Michael

[itolkov]

Attachment: slider-bg-3.png

Here's the png again.

[sagetrac-mabshoff]

comment:9

Merged slider-bg-3.png in Sage 3.1.alpha0. Thanks Igor for the png. In the future please export a git style patch in case binaries are involved.

Cheers,

Michael