Doctest failures with alarm on OS X #36944
Labels
Milestone
Comments
5 tasks
|
Thanks for opening this.
|
|
The tokenpool code does play with SIGALRM. https://github.com/milahu/gnumake-tokenpool/blob/main/py/src/gnumake_tokenpool/tokenpool.py#L178 |
5 tasks
|
#36948 has a tentative solution. I haven't been able to reproduce the failure yet locally, so if you have a chance, please try |
|
No, it doesn't fix it. |
Confirmed, doesn't fix it for me either. |
|
Looks like I may have a solution that uses cysignals in combination with tokenpool. |
|
OK, the new version of #36948 does the trick according to my local tests |
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Dec 23, 2023
…mInterrupt` problems <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> The new release 0.0.4 provides cysignals integration: - milahu/gnumake-tokenpool#4 Fixes sagemath#36944 To verify that the tokenpool mechanism is being used: ``` $ DEBUG_JOBCLIENT=1 make ptest ``` <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36948 Reported by: Matthias Köppe Reviewer(s): John H. Palmieri
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Dec 24, 2023
…mInterrupt` problems
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
The new release 0.0.4 provides cysignals integration:
- milahu/gnumake-tokenpool#4
Fixes sagemath#36944
To verify that the tokenpool mechanism is being used:
```
$ DEBUG_JOBCLIENT=1 make ptest
```
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36948
Reported by: Matthias Köppe
Reviewer(s): John H. Palmieri
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Dec 26, 2023
…mInterrupt` problems
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
The new release 0.0.4 provides cysignals integration:
- milahu/gnumake-tokenpool#4
Fixes sagemath#36944
To verify that the tokenpool mechanism is being used:
```
$ DEBUG_JOBCLIENT=1 make ptest
```
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36948
Reported by: Matthias Köppe
Reviewer(s): John H. Palmieri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps To Reproduce
With OS X 13.6.3 (Intel) and OS X 14.2 (Apple M2), Sage 10.3.beta2 and later,
make ptestandmake ptestlongproduce failures that were not present with 10.3.beta1.Expected Behavior
Tests which used to pass should pass.
Actual Behavior
As noted, tests do not pass. The end of
make ptestlongreports:The first failure, for example:
Additional Information
git bisectled me to that, and then independently 10.3.beta1 + that PR led to the failures.sage -tp.make test,make ptest,make ptestlong.Environment
Checklist
The text was updated successfully, but these errors were encountered: