Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipython 8.19.0 breaks sagemath, making it unusable #36975

Closed
tornaria opened this issue Dec 27, 2023 · 9 comments
Closed

ipython 8.19.0 breaks sagemath, making it unusable #36975

tornaria opened this issue Dec 27, 2023 · 9 comments

Comments

@tornaria
Copy link
Contributor

See: ipython/ipython#14223 (comment)

My workaround in void-linux/void-packages#47913 is to patch out the buggy feature. Cf https://github.com/void-linux/void-packages/blob/master/srcpkgs/python3-ipython/patches/fix-sagemath-prompt.patch.

Other than this, everything seems ok with ipython 8.19 (at least all doctests pass).
@mkoeppe
Copy link
Member

mkoeppe commented Dec 27, 2023

They also dropped Python 3.9 IIRC, so we won't merge it soon

@mkoeppe
Copy link
Member

mkoeppe commented Dec 27, 2023

But we should add an install-requires upper bound

@tornaria tornaria mentioned this issue Dec 27, 2023
Merged
@tornaria
Copy link
Contributor Author

But we should add an install-requires upper bound

Upstream is aware of the issue and will fix it in an upcoming 8.19.1. Better to only skip 8.19.0. See: ipython/ipython#14223 (comment)

@tornaria
Copy link
Contributor Author

@antonio-rojas it might be the case that sagemath is currently broken on arch (?)

@done-with-fish
Copy link

@antonio-rojas it might be the case that sagemath is currently broken on arch (?)

Yes, sagemath is currently broken on arch (which is why I'm lurking here!).

@tornaria
Copy link
Contributor Author

@antonio-rojas it might be the case that sagemath is currently broken on arch (?)

Yes, sagemath is currently broken on arch (which is why I'm lurking here!).

The patch I linked above is safe and works fine (it's what we are shipping on void linux). Or else wait a few days for upstream to release 8.19.1 and arch to ship it (or downgrade ipython to 8.18 if that's possible).

@Chaman-veteran Chaman-veteran mentioned this issue Jan 2, 2024
Closed
2 tasks
@Carreau
Copy link

Carreau commented Jan 8, 2024

8.20 published with a fix and 8.19 yanked. Apologies again for the breakage.

@Carreau Carreau mentioned this issue Jan 8, 2024
Open
1 task
@amca01
Copy link

amca01 commented Jan 15, 2024

I've just discovered this when experimenting with Sage in the console - using a fairly recently upgraded (4 days ago) Arch linux. Thanks for the fix - I've just seen that ipython is indeed upgradeable via pacman, so I'll do another system upgrade.

@mkoeppe mkoeppe mentioned this issue Jan 31, 2024
Merged
Carreau added a commit to ipython/ipython that referenced this issue Feb 6, 2024
@Carreau
.github/workflows/downstream.yml: Test with sagemath-repl (#14317)
ce22aa2 
Adding a lightweight test with SageMath using the modularized
distribution https://pypi.org/project/sagemath-repl/ of the Sage
library.

Motivated by sagemath/sage#36975,
#14223 (comment),
sagemath/sage#36993,
sagemath/sage#37031 @Carreau
@mkoeppe
Copy link
Member

mkoeppe commented Feb 7, 2024

As 8.19.0 has been yanked - https://pypi.org/project/ipython/#history - I think we can close this

@mkoeppe mkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Carreau @tornaria @amca01 @mkoeppe @done-with-fish