Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in set_edge_label #3703

Closed
rlmill mannequin opened this issue Jul 22, 2008 · 6 comments
Closed

bug in set_edge_label #3703

rlmill mannequin opened this issue Jul 22, 2008 · 6 comments

Comments

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jul 22, 2008

sage: G = Graph({0:{1:1}}, implementation='c_graph')
sage: G.num_edges()
1
sage: G.set_edge_label(0,1,1)
sage: G.num_edges()
2

Component: graph theory

Issue created by migration from https://trac.sagemath.org/ticket/3703

@rlmill rlmill mannequin added this to the sage-3.0.6 milestone Jul 22, 2008
@rlmill rlmill mannequin added c: graph theory labels Jul 22, 2008
@rlmill rlmill mannequin self-assigned this Jul 22, 2008
@rlmill rlmill mannequin added the s: needs review label Jul 22, 2008
@jasongrout
Copy link
Member

comment:1

Attachment: trac3703-set_edge_label.patch.gz

Positive review. Good catch!

Passes doctests in graphs/.py, graphs/.pyx, and graphs/base/*.pyx

@rlmill
Copy link
Mannequin Author

rlmill mannequin commented Jul 22, 2008

comment:2

I spent most of a day hunting for this one; I wasn't expecting to find it where I did. I was writing new code, so I was convinced it was there...

@jasongrout
Copy link
Member

comment:3

That's a nice blog post you have talking about finding this bug:

http://rlmill.blogspot.com/2008/07/adinkras.html

@williamstein williamstein modified the milestones: sage-3.0.6, sage-3.1 Jul 25, 2008
@rlmill
Copy link
Mannequin Author

rlmill mannequin commented Jul 30, 2008

comment:5

This has been sitting positively reviewed for several release cycles now. What's going on??

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jul 30, 2008

comment:6

Replying to @rlmill:

This has been sitting positively reviewed for several release cycles now. What's going on??

3.0.5 was supposed to be ultra stable, but one bug introduced mandated another 3.0.6 stable release. So this patch fell by the side. It will be merged in 3.1.alpha0 in a couple minutes provided the doctests pass.

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jul 30, 2008

comment:7

Merged in Sage 3.1.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jul 30, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants