Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegularSequence.subsequence broken for zero sequence #37282

Closed
2 tasks done
cheuberg opened this issue Feb 10, 2024 · 0 comments · Fixed by #37283
Closed
2 tasks done

RegularSequence.subsequence broken for zero sequence #37282

cheuberg opened this issue Feb 10, 2024 · 0 comments · Fixed by #37283
Labels
t: bug

Comments

@cheuberg
Copy link
Contributor

Steps To Reproduce

R = RegularSequenceRing(2, QQ)
z = R.zero()
z.subsequence(1, 1)

Expected Behavior

2-regular sequence 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ...

Actual Behavior

Traceback (most recent call last):
...
  File "/local/cheuberg/local/sage-10.3.beta7/src/sage/combinat/regular_sequence.py", line 850, in subsequence
    vector(chain.from_iterable(
  File "sage/modules/free_module_element.pyx", line 587, in sage.modules.free_module_element.vector
  File "sage/modules/free_module_element.pyx", line 690, in sage.modules.free_module_element.prepare
TypeError: unable to find a common ring for all elements

Additional Information

Cc: @dkrenn

Environment

- **OS**: Ubuntu 20.04
- **Sage Version**: 10.3.beta7

Checklist

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
  • I have read the documentation and troubleshoot guide
@cheuberg cheuberg mentioned this issue Feb 10, 2024
Merged
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this issue Feb 18, 2024
sagemathgh-37283: Fix RegularSequence.subsequence for zero sequence
ea91293 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
Fixes sagemath#37282

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
Cc: @dkrenn
    
URL: sagemath#37283
Reported by: cheuberg
Reviewer(s): cheuberg, Sebastian A. Spindler
vbraun pushed a commit to vbraun/sage that referenced this issue Feb 19, 2024
sagemathgh-37283: Fix RegularSequence.subsequence for zero sequence
2f40c52 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
Fixes sagemath#37282

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
Cc: @dkrenn
    
URL: sagemath#37283
Reported by: cheuberg
Reviewer(s): cheuberg, Sebastian A. Spindler
@vbraun vbraun closed this as completed in 99fd4f4 Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RegularSequence.subsequence for zero sequence cheuberg/sage
1 participant
@cheuberg