Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Conda is broken because macos-latest is now Apple Silicon #37997

Closed
mkoeppe opened this issue May 13, 2024 · 0 comments · Fixed by #37998
Closed

CI Conda is broken because macos-latest is now Apple Silicon #37997

mkoeppe opened this issue May 13, 2024 · 0 comments · Fixed by #37998
Milestone
sage-10.4

Comments

@mkoeppe
Copy link
Member

mkoeppe commented May 13, 2024 •
edited
Loading

... and the wrong conda-lock file is used.

We should perhaps switch to multi-platform lock files - https://conda.github.io/conda-lock/basic_usage/
@mkoeppe mkoeppe mentioned this issue May 13, 2024
Merged
5 tasks
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 14, 2024
vbraun pushed a commit to vbraun/sage that referenced this issue Jun 22, 2024
sagemathgh-37998: Update conda-lock files, rename macOS conda-lock fi…
4a80002 
…les to match CI Conda, remove unexplained duplicate lock files

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

The renaming is done so that the fix here can take effect on PR runs via
the "CI Fix" mechanism (as changes to the workflow files themselves
cannot take effect).
- Moreover, making arm64 the default platform for macOS makes sense
because all new macOS machines use this platform.

And update by running `.github/workflows/conda-lock-update.py` for all
architectures.

- Workflow matrix variables now contain `-latest`, to add tests for the
macOS x86_64 platform (runner name: `macos-13`)

- Removes some unexplained duplications (both `arm` and `arm64` files
for macOS, both `aarch` and `aarch64` for Linux)

- Fixes sagemath#37997

Author: @mkoeppe, @gmou3

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#38033 (split out from here)
- Depends on sagemath#38034 (split out from here)
- Depends on sagemath#38222
    
URL: sagemath#37998
Reported by: Matthias Köppe
Reviewer(s):
@vbraun vbraun closed this as completed in 82bc2c3 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sage-10.4
1 participant
@mkoeppe