Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: linbox-1.7.0 fails to build #38002

Closed
2 tasks done
vbraun opened this issue May 13, 2024 · 4 comments · Fixed by #38020
Closed
2 tasks done

macOS: linbox-1.7.0 fails to build #38002

vbraun opened this issue May 13, 2024 · 4 comments · Fixed by #38020

Comments

@vbraun
Copy link
Member

vbraun commented May 13, 2024

Steps To Reproduce

Possibly specific to x86 / OSX 14, not sure:

[fflas_ffpack-2.5.0] [spkg-install] libtool: link: g++ -std=gnu++11 -std=gnu++11 -dynamiclib  -o .libs/libfflas_c.1.dylib  .libs/fflas_lvl1.o .libs/fflas_lvl2.o .libs/fflas_lvl3.o .libs/fflas_sparse.o   -L/Users/kwankyu/GitHub/sage-dev/local/lib ./.libs/libfflas.dylib -lopenblas  -O2 -march=native -g -O2 -Wl,-rpath -Wl,/Users/kwankyu/GitHub/sage-dev/local/lib -Wl,-rpath -Wl,/Users/kwankyu/GitHub/sage-dev/local/lib   -install_name  /Users/kwankyu/GitHub/sage-dev/local/lib/libfflas_c.1.dylib -compatibility_version 2 -current_version 2.0 -Wl,-single_module
[fflas_ffpack-2.5.0] [spkg-install] Undefined symbols for architecture x86_64:
[fflas_ffpack-2.5.0] [spkg-install]   "Givaro::Integer::operator%(unsigned long long) const", referenced from:
[fflas_ffpack-2.5.0] [spkg-install]       Givaro::Modular<double, double, void>::init(double&, Givaro::Integer const&) const in fflas_lvl1.o
[fflas_ffpack-2.5.0] [spkg-install]       Givaro::Modular<double, double, void>::init(double&, Givaro::Integer const&) const in fflas_lvl2.o
[fflas_ffpack-2.5.0] [spkg-install]       Givaro::Modular<double, double, void>::init(double&, Givaro::Integer const&) const in fflas_lvl3.o
[fflas_ffpack-2.5.0] [spkg-install] ld: symbol(s) not found for architecture x86_64
[fflas_ffpack-2.5.0] [spkg-install] clang: error: linker command failed with exit code 1 (use -v to see invocation)
[fflas_ffpack-2.5.0] [spkg-install] make[7]: *** [libfflas_c.la] Error 1
[fflas_ffpack-2.5.0] [spkg-install] make[7]: *** Waiting for unfinished jobs....
[fflas_ffpack-2.5.0] [spkg-install] make[6]: *** [all-recursive] Error 1
[fflas_ffpack-2.5.0] [spkg-install] make[5]: *** [all-recursive] Error 1
[fflas_ffpack-2.5.0] [spkg-install] make[4]: *** [all-recursive] Error 1
[fflas_ffpack-2.5.0] [spkg-install] make[3]: *** [all] Error 2
[fflas_ffpack-2.5.0] [spkg-install] ********************************************************************************
[fflas_ffpack-2.5.0] [spkg-install] Error building fflas_ffpack-2.5.0

Adding -lgivaro to the linker command line fixes at least that command

Expected Behavior

Builds

Actual Behavior

fflas_ffpack-2.5.0 fails to build

Additional Information

No response

Environment

- **OS**: macOS 
- **Sage Version**: 10.4.beta6

Checklist

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
  • I have read the documentation and troubleshoot guide
@jhpalmieri
Copy link
Member

jhpalmieri commented May 13, 2024

I see this with an Apple Silicon machine, too, OS X 14.4.1.

@mkoeppe
Copy link
Member

mkoeppe commented May 13, 2024

@vbraun
Copy link
Member Author

vbraun commented May 17, 2024

PR at #38020

@mkoeppe
Copy link
Member

mkoeppe commented May 17, 2024

Just running autoreconf to get a newer libtool also does the job, but we can't do that in spkg-install.

vbraun pushed a commit to vbraun/sage that referenced this issue May 18, 2024
Just hack the missing -lgivaro into the linker command, see also
linbox-team/fflas-ffpack#391 for the real bug

Closes sagemath#38002

URL: sagemath#38020
Reported by: Volker Braun
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue May 18, 2024
Just hack the missing -lgivaro into the linker command, see also
linbox-team/fflas-ffpack#391 for the real bug

Closes sagemath#38002

URL: sagemath#38020
Reported by: Volker Braun
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue May 24, 2024
    
Just hack the missing -lgivaro into the linker command, see also
linbox-team/fflas-ffpack#391 for the real bug

Closes sagemath#38002
    
URL: sagemath#38020
Reported by: Volker Braun
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants