Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the cmap option for vector field plots #4103

Closed
jasongrout opened this issue Sep 12, 2008 · 3 comments
Closed

Delete the cmap option for vector field plots #4103

jasongrout opened this issue Sep 12, 2008 · 3 comments
Assignees
@williamstein
Labels
c: graphics p: minor / 4 t: bug
Milestone
sage-3.1.3

Comments

@jasongrout
Copy link
Member

The cmap argument for vector field plots is not used. Does anyone know why it's there? I don't think it's even valid matplotlib code.

This patch deletes the option.

Component: graphics

Issue created by migration from https://trac.sagemath.org/ticket/4103
@jasongrout jasongrout added this to the sage-3.1.3 milestone Sep 12, 2008
@jasongrout
Copy link
Member Author

Attachment: plot_vector_field_cmap.patch.gz

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Sep 19, 2008

comment:2

Patch looks good to me. Assuming it passes doctests (which are running now) this is a positive review.

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Sep 19, 2008

comment:3

Merged in Sage 3.1.3.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Sep 19, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: graphics p: minor / 4 t: bug
Projects
None yet
Milestone
sage-3.1.3
Development

No branches or pull requests
2 participants
@jasongrout @williamstein