notebook -- when email system on, registration is broken

[TimothyClemans]

Depends on #4551

CC: @wjp

Component: notebook

Author: Timothy Clemans

Reviewer: Willem Jan Palenstijn

Merged: Sage 4.1.2.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/4552

[TimothyClemans]

Attachment: sage-4552.patch.gz

[boothby]

comment:2

Timothy -- please describe the problem that this is supposed to fix. "Depends on #4551" is insufficient.

[TimothyClemans]

comment:3

If the email config is set to True then registration doesn't work.

[wjp]

Attachment: trac_4552-notebook_account_email.patch.gz

modified patch without dependency on #4551

[wjp]

comment:4

I modified the attached patch to remove the dependency on #4551. (Only apply trac_4552-notebook_account_email.patch)

To elaborate on the problem a little bit: the problem was that the value of the 'email' input box was never read from the form. As a result, when the verification code tries to access it, the server gets a KeyError.

For what it's worth, I give a positive review to adding 'email' to 'input_boxes', which is how Timothy's patch fixes the problem.

[wjp]

comment:6

It turns out the dependency on #4551 was really a dependency on #4135. Now that that has been merged, positive review.

Note to release manager: apply only the _original_ patch (sage-4552.patch)

[sagetrac-mvngu]

Reviewer: Willem Jan Palenstijn

[sagetrac-mvngu]

Author: Timothy Clemans

[sagetrac-mvngu]

comment:7

Merged sage-4552.patch.

[sagetrac-mvngu]

Merged: Sage 4.1.2.alpha1