New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notebook -- user management features #4135
Comments
comment:3
I'm trying to review this, but I can't get the patches to apply. I'm starting from a clean 3.1.2 tree. Which patches should I apply, and in what order? Should I use a different version to apply patches against? |
comment:4
This ticket has been rebased. |
comment:5
It seems that the /user page isn't found with an existing notebook. I created a new notebook and the /users page came up. |
comment:6
I've had trouble in the pass with getting administrative users recognized by the Notebook. |
comment:7
I've applied all the necessary patches to a 3.1.3alpha1 tree, but when I try to start Sage, I get:
That's just the last part of the traceback; the rest doesn't seem so interesting...but let me know if you want to see it. I've looked through the patches from 4134, 2407, and this ticket, and I don't see where the file |
comment:8
Replying to @dandrake:
Did you do |
comment:9
Or if you're using queues and don't want to mess up your tree, go to $SAGE_ROOT/data/extcode and do:
|
comment:12
Apply just extcode-4135_1.patch and sage-4145_3.patch |
comment:14
Depends on #3950 |
comment:15
Don't apply extcode-4135_1.patch afterall |
comment:16
Apply sage-4135_3.patch and sage-4135_4.patch |
Attachment: trac_4135.patch.gz |
comment:23
Hmm, given this is rather crucial and hard to test code I would be happy if someone else did take another look, so "needs review" to attract someone else. Cheers, Michael |
comment:24
Applied patch to r12658. Everything works perfectly except for the cancel link in the Account Settings page. It links to /home, leading to a 404 Error. I believe /home// is the proper way to link it. |
comment:25
Replying to @TimDumol:
I see the same error. I put in a |
comment:26
For the cancel button not working, see the patch at #6856. (I created that ticket before seeing the issue was already mentioned here.) |
comment:27
I don't understand how (or if?) this patch implements the mentioned temporary password functionality. There is a new '__temporary_password' variable, but that doesn't seem to be used. |
comment:28
Replying to @wjp:
When one adds a new user, you get a page saying "The temporary password for the new user foo is 52oN5g2a". Unfortunately, that password does not seem to be temporary; the new user can log in and out, and back in again with that password. When I read "temporary password", I think that the user will be able to log in once, and then be forced to change the password right away. Another problem with the temporary password page is that the title of the page is "Error", even though there's no error. That said: this patch, along with #6856 (which I just positively reviewed) does give us the basic functionality for adding users and resetting passwords from inside the notebook, which is something I'd really like. The last patch applies cleanly to 4.1.1. What do people think of merging this and opening a new ticket to fix the temporary password bits? (Or changing this patch so that it doesn't claim that the new password is temporary?) |
comment:29
I'd agree with not holding up this patch because of this, because it is already a very useful feature to have. This patch does probably have to be rebased against #6568, though. |
rebased against 4.1.1 + #6568 |
Author: Timothy Clemans |
comment:30
Attachment: trac_4135.4.patch.gz Rebased patch up. This should apply cleanly to the release manager's 4.1.2.alpha tree. I am going to change this to a positive review and open a new ticket for the temporary password business. Release manager: apply only attachment: trac_4135.4.patch. |
Reviewer: Tim Dumol, Dan Drake |
comment:31
The temporary password ticket is #6871. |
comment:32
I got two hunk failures when merging
|
comment:33
Replying to @sagetrac-mvngu:
(snip) I tried applying the patch here on top of a 4.1.1 tree that already had the patches from those three tickets applied, and I get a different hunk that won't apply. Perhaps I'll wait for the alpha0 tarball to be released and rebase the patch here based on that...or, you could |
Attachment: trac_4135.5.patch.gz rebased against mvngu's 4.1.2.alpha0 merge tree |
comment:34
Merged |
Merged: Sage 4.1.2.alpha0 |
New features:
Component: notebook
Author: Timothy Clemans
Reviewer: Tim Dumol, Dan Drake
Merged: Sage 4.1.2.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/4135
The text was updated successfully, but these errors were encountered: