Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move existing javascript packages in extcode to their own spkg packages #4700

Closed
jasongrout opened this issue Dec 5, 2008 · 6 comments
Closed

Comments

@jasongrout
Copy link
Member

This ticket moves the jsmath, jquery, jqueryui, and jsmath-image-fonts packages to their own spkgs that install in local/notebook/javascript.

Sorry, mabshoff; it was much easier to group these very related and similar tasks together.

The spkgs are at:

http://sage.math.washington.edu/home/jason/notebook/jquery-1.2.6.spkg

http://sage.math.washington.edu/home/jason/notebook/jqueryui-1.6r807svn.spkg

http://sage.math.washington.edu/home/jason/notebook/jsmath-3.6a.spkg

http://sage.math.washington.edu/home/jason/notebook/jsmath-image-fonts-1.3p0.spkg

The (huge) patch that deletes things from the extcode repository is at

http://sage.math.washington.edu/home/mabshoff/extcode-remove-javascript-packages.patch (apply to the extcode repository; we might reset the extcode history, as mabshoff suggested on #4267).

Component: notebook

Issue created by migration from https://trac.sagemath.org/ticket/4700

@jasongrout
Copy link
Member Author

comment:1

This ticket also takes the opportunity to update each of the javascript packages to the latest version (as of late October, 2008). Some of the changes in the patch reflect the updating (primarily, the updating of jqueryui).

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Dec 5, 2008

comment:2

No,

the whole point was that

  1. these tasks are independent
  2. this is again a composite ticket just like remove javascript code from extcode repository #4267

So: invalid.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Dec 5, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin removed this from the sage-3.2.2 milestone Dec 5, 2008
@williamstein
Copy link
Contributor

comment:3

OK, guys calm down. It will be _massively_ easier referee wise if you can break this up into independent tasks, especially because there's still a lot of work to integrate this into sage, even after handing it off. Please please please Jason can you split this into smaller well-defined tasks? Thanks!!

@jasongrout
Copy link
Member Author

Attachment: javascript-spkg.patch.gz

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Dec 5, 2008

comment:4

To elaborate some more why these tickets need to be split up:

  • verifying that the updated jsmath.spkg works is trivial
  • anything touching jquery needs to be reviewed in much more detail, i.e. somebody needs to check that DSage still works, i.e. its GUI
  • jsmath-image-fonts-1.3p0.spkg is an optional spkg, so it should be trivial to review

Mixing and matching seemingly related tickets and then ending up piling fixes on top has proven a disaster time after time, so let's please be nice about this and get this resolved.

Cheers,

Michael

PS: Sorry if my tone was out of line, I had just woken up :)

@jasongrout
Copy link
Member Author

comment:5

Okay; I saw all of these tasks as very similar, hence the same ticket. It'll be a lot more work to split it up further than this, but I'll get to it eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants