New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tinymce: fix creation of text cells to not cause duplicate ids and not be considered compute cells #5025
Comments
comment:1
I can reproduce (1) on sage-3.3.alpha0. I think the new text cells have to have some additional properties, based on the server log's: line 1049, in render |
comment:2
Okay, the (soon-to-be) attached patch fixes (1) and also fixes the bug mhampton pointed out a while ago that there are multiple cells with the same id. (2) This is how standard linking works in web browsers in general, and is just implemented in TinyMCE to be consistent with most other links on the internet. I think I'd classify (2) as a wontfix, since there are standard mechanisms for opening a link in another tab that are widely known and understood. (3) This does seem weird, but we'd need some steps to reproduce the problem. Hence, I'd say that this ticket is really concerned with the bug in (1), which is addressed in the patch. |
comment:3
These bugfixes also correct a number of small issues that were bugging people too. |
comment:5
(I found one other small issue, which I corrected in the refreshed patch I just attached.) |
comment:6
I applied the patch, and got the following when I clicked on a worksheet:
|
comment:8
Okay, this looks like a conflict with mhansen's new percent directive handling. I'm CCing him to see if he knows what is going on here. |
comment:9
Actually, mhansen, is this a problem with your percent directive patch? In particular, if you create a worksheet with a text cell, is it asked for percent directives, like appears what is happening above? |
comment:10
I'm having a hard time duplicating this problem with Sage 3.3.alpha2. |
comment:11
This patch makes the tinymce text cells not break the navigation and evaluate-all functionalities of the notebook. Without this patch, the navigation arrows stop at text cells and other things become frustratingly cumbersome, so I'm marking this as critical, since tinymce is already merged. Boothby, can you post the worksheet you had a problem with and confirm that the problem exists on 3.3alpha2? |
comment:12
I can reproduce this on 3.3alpha2 by: creating a new worksheet entering 1+1 and evaluating the first cell create a text cell below all other cells. Save changes to text cell create a calculation cell below all other cells. Enter 1+1 and evaluate Select "Evaluate All" from the menu. |
comment:13
Okay, I reproduced this with the above steps with a stock sage-3.3alpha2 (without this patch applied), so this patch is not at fault here. Can we merge this patch and open up another (critical) ticket for the issue with Text cells above? In other words, can someone change this to a positive review, since this patch isn't the one causing the problem? |
comment:14
I found one problem in the above patch. I'm posting an updated patch soon. |
comment:15
Attachment: trac_5025-tinymce_bugfix.patch.gz Okay, the bug should be fixed. The only change is on line 3354 or so, where when inserting a text cell after all other cells, the previous patch called insert_new_cell_after, but should have called insert_new_text_cell_after. The refreshed patch corrects this. |
comment:16
My testing gives that this mysteriously makes the Edit button non-functional, or rather that the Edit button gives the usual interface but without any actual text to edit, not even a blank box - nothing! I also once or twice got a similar error to Boothby's where the cell instance was missing a different attribute, but couldn't get it to reproduce reliably. (BTW, I also occasionally get this mysterious addition of new cells, but it's extremely difficult to reproduce and of course it's unrelated to the current patch.) |
comment:17
The edit button works fine for me. I'm using FF 3.0.5 on Ubuntu Intrepid. Just to clarify, the edit button works fine for you without this patch applied. You apply the patch, and the edit button no longer works. Is that correct? What browser and OS are you using? The bug I fixed when I refreshed the patch a few hours ago should fix the cell instance missing an attribute problem. What was the error message? |
comment:18
kcrisman: also, are you using sage 3.3 alpha 2? This patch depends on the alpha2 (that alpha contains, for example, the other tinymce patches) |
comment:19
Having looked at the patch and tested it on alpha2 on Firefox on Linux and Safari on OS X. I think it can go into alpha3 where it will get more widespread testing. I have no idea what is going on with kcrisman's system. I'll dedicate some time to take care of all of this before 3.3. |
comment:21
Merged in Sage 3.3.alpha3. Cheers, Michael |
comment:23
Replying to @jasongrout:
That could be the problem. I just don't know why Edit would work without this patch, then not work with the patch, as well as why this patch would even apply correctly! Don't worry, I'll let you know if it happens in 3.3 proper - my sense is not, based on mhansen's review. |
This was posted to the mailing list about #4705:
CC: @mwhansen
Component: notebook
Issue created by migration from https://trac.sagemath.org/ticket/5025
The text was updated successfully, but these errors were encountered: