Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab-completion menu creates two copies of the choice made #5293

Closed
sagetrac-mhampton mannequin opened this issue Feb 17, 2009 · 8 comments
Closed

tab-completion menu creates two copies of the choice made #5293

sagetrac-mhampton mannequin opened this issue Feb 17, 2009 · 8 comments

Comments

@sagetrac-mhampton
Copy link
Mannequin

sagetrac-mhampton mannequin commented Feb 17, 2009

In sage-3.3.rc0 (presumable from some patch in an alpha release) tab-completion is somewhat broken in the notebook. If you tab-complete and there is more than one possible completion, if you choose from the drop-down menu and press enter you get the entire command repeated, for example:

QQ. [press tab, get menu, choose absolute_degree and press enter]
QQ.absolute_degreeQQ.absolute_degree

This is currently effecting sagenb's rc0, and has been confirmed on several other installs.

I am not sure where to begin to track this down, or what patch caused it.

Component: notebook

Keywords: tab completion

Issue created by migration from https://trac.sagemath.org/ticket/5293

@sagetrac-mhampton
Copy link
Mannequin Author

sagetrac-mhampton mannequin commented Feb 17, 2009

Changed keywords from none to tab completion

@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-3.4.1 milestone Feb 17, 2009
@sagetrac-mhampton
Copy link
Mannequin Author

sagetrac-mhampton mannequin commented Feb 17, 2009

comment:4

This seems to be caused by #4440. I am working on a patch now.

@jasongrout
Copy link
Member

comment:5

I am just confirming that this is caused by #4440. I found this with the (very cool) hg bisect command and then hand-tested before/after the patch was committed.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Feb 17, 2009

comment:6

Fixed by reverting #4440 for now.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Feb 17, 2009
@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-3.4.1, sage-3.3 Feb 17, 2009
@boothby
Copy link

boothby commented Feb 19, 2009

comment:8

Attachment: 5293.patch.gz

@boothby
Copy link

boothby commented Feb 19, 2009

comment:9

patch depends on #4440

@sagetrac-mhampton
Copy link
Mannequin Author

sagetrac-mhampton mannequin commented Feb 19, 2009

comment:10

This appears to fix the side-effects from #4440. Patch applies to rc0, which still had #4440 applied.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Feb 20, 2009

comment:11

Merged in Sage 3.3.rc3.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Feb 20, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants