New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sage 3.3: numerical noise in rings/polynomial/complex_roots.py on cicero & fulvia #5378
Comments
comment:1
Hmm, the numerical noise of the imaginary part of the root causes the order of the roots for printing to be flipped. I am not sure what to do here except for picking another polynomial, but I have not looked into this in any detail since we might have this particular root for a good reason. Cheers, Michael |
comment:2
I don't remember anything special about that polynomial, so I'm fine with changing it. Other possibilities would include changing the sorting. One possibility would be to remove the code that puts real roots first; another possibility would be to special-case complex interval roots in the sorting, and say that if the imaginary part of a root is an interval that contains 0 then it should sort with the real roots. |
comment:3
Move this to 3.4.1 since I am closing this as dupe of #5559. Cheers, Michael |
comment:4
The following illustrates the problem and a potential solution:
On another machine we get:
Patch coming up. Cheers, Michael |
Attachment: trac_5378.patch.gz |
comment:6
Builds and tests just fine. Positive review. |
comment:7
Merged in Sage 3.4.1.rc4. Cheers, Michael |
CC: @sagetrac-cwitty
Component: doctest coverage
Issue created by migration from https://trac.sagemath.org/ticket/5378
The text was updated successfully, but these errors were encountered: