Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forming ideals in IntegerModRing_generic does not work #5666

Closed
JohnCremona opened this issue Apr 2, 2009 · 5 comments
Closed

forming ideals in IntegerModRing_generic does not work #5666

JohnCremona opened this issue Apr 2, 2009 · 5 comments

Comments

@JohnCremona
Copy link
Member

It is impossible to create ideals in rings of the form Integers mod n:

sage: R = Integers(10)
sage: R.ideal(1)
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)

/home/masgaj/.sage/temp/host_56_150/5831/_home_masgaj__sage_init_sage_0.py
in <module>()

/local/jec/sage-3.4.1.alpha0/local/lib/python2.5/site-packages/sage/rings/quotient_ring.pyc
in ideal(self, *gens, **kwds)
   487             gens = gens[0]
   488         from
sage.rings.polynomial.multi_polynomial_libsingular import
MPolynomialRing_libsingular
--> 489         if not
isinstance(self.__R,MPolynomialRing_libsingular) and not
self.__R._has_singular:
   490             # pass through
   491             MPolynomialRing_generic.ideal(self,gens,**kwds)

AttributeError: 'sage.rings.integer_ring.IntegerRing_class' object has
no attribute '_has_singular'
sage: R.ideal([2,4])
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)

(as above)

It looks as if the ideal() method for class QuotientRing_generic is
only really geared to polynomial ring quotients.

Component: algebra

Author: William Stein

Reviewer: Rob Beezer

Merged: sage-4.3.1.rc1

Issue created by migration from https://trac.sagemath.org/ticket/5666

@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-4.0 milestone Apr 23, 2009
@williamstein
Copy link
Contributor

comment:2

Attachment: trac_5666.patch.gz

@rbeezer
Copy link
Mannequin

rbeezer mannequin commented Jan 18, 2010

Author: William Stein

@rbeezer
Copy link
Mannequin

rbeezer mannequin commented Jan 18, 2010

comment:3

Passes tests and allows creation of ideals within rings of integers mod n.

But it seems the resulting ideals still need some work, for example _contains_() in rings.ideal.Ideal_generic is not implemented.

sage: R=Integers(40)
sage: Q=R.ideal([2,3])
sage: type(Q)
<class 'sage.rings.ideal.Ideal_generic'>
sage: 1 in Q
------------------
NotImplementedError
<snip>

@rbeezer
Copy link
Mannequin

rbeezer mannequin commented Jan 18, 2010

Reviewer: Rob Beezer

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 18, 2010

Merged: sage-4.3.1.rc1

@rlmill rlmill mannequin removed the s: positive review label Jan 18, 2010
@rlmill rlmill mannequin closed this as completed Jan 18, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants