New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update NetworkX to version 0.99 #6041
Comments
comment:1
A new spkg is up at http://sage.math.washington.edu/home/mvngu/patch/networkx-0.99.p1.spkg Unfortunately, as I suspected version 0.99 of NetworkX breaks a lot of doctests:
I'll upload patches against the relevant modules shortly, unless someone who is awake beats me to it (I'm going to sleep now :-). |
comment:2
You should definitely get a good night's sleep before you tackle that! I would suggest you start by seeing what needs to be fixed to get the doctests in
to work properly. This is where Sage and NetworkX mainly plug in to each other. Once those are fixed, I expect much of the rest will be already done. |
comment:3
I managed to get all doctests in
But the following doctests failed:
It looks like anything under |
comment:4
Replying to @sagetrac-mvngu:
Incorrect. NetworkXGraphBackend is simply a wrapper for a NetworkX graph, which can be directed, or have multiple edges.
This isn't irrelevant, as Sage graphs can have loops or multiedges set. What needs to happen is for loops and multiedges to become properties of the backend, and for the appropriate work to go on there. We still need to support these options. You should be working on top of the
Next time you could probably attach the diff to the ticket... :)
Don't forget all of the rest of Sage! I think you'll find it much easier to adapt the backend to behave exactly as before. Then, all the other doctests should pass - that's what they're there for! |
comment:5
Replying to @rlmill:
Agreed. Version 0.99 now has:
http://networkx.lanl.gov/reference/api_changes.html Previously
Thanks you for the pointer.
No, the diff isn't meant to be committed in the future. It's there for discussion and to explore ways to maintain compatibility with the existing API in
OK, let me see what I can do. |
comment:6
Replying to @sagetrac-mvngu:
Actually, there were also
You can still post diffs as attachments. It makes the discussion much easier to follow when you're reading the ticket, and it keeps clutter down. Just add the note "not to be applied" if you're worried...
It should be possible to get all of the doctests in Sage working by changing only things which call |
comment:7
There is another patch at #6085 now: You should be working on top of |
comment:9
This ticket is now a duplicate of #7608. The latter has a patch and an updated NetworkX 1.0rc1 package. |
As the subject says. This is a follow-up to #5934.
CC: @rlmill @jasongrout
Component: graph theory
Issue created by migration from https://trac.sagemath.org/ticket/6041
The text was updated successfully, but these errors were encountered: