Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sage -sync-build smarter. #6147

Closed
craigcitro opened this issue May 28, 2009 · 3 comments
Closed

Make sage -sync-build smarter. #6147

craigcitro opened this issue May 28, 2009 · 3 comments

Comments

@craigcitro
Copy link
Member

As it stands, sage -sync-build simply looks for corresponding C/C++ source files for a given .o or .so file. However, since the vast majority of such files are generated by .pyx files, this means that if you simply delete the .pyx file without deleting the generated C/C++ file, then it won't clean out the compiled object file, which is bad.

We fix this by searching for .pyx files instead. However, there are several C/C++ source files in the sage tree which aren't created from Cython; to keep track of these, we walk through the list of extensions (which is generated by module_list.py and sage/ext/gen_interpreters.py) and make a list of these non-Cython source files, then don't delete things that occur there.

CC: @mwhansen @williamstein

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/6147

@craigcitro craigcitro added this to the sage-4.0.1 milestone May 28, 2009
@craigcitro craigcitro self-assigned this May 28, 2009
@craigcitro
Copy link
Member Author

apply to repo in $SAGE_LOCAL/bin

@craigcitro
Copy link
Member Author

comment:1

Attachment: trac-6147-bin.patch.gz

I'm adding some potential referees to the cc field ...

@mwhansen
Copy link
Contributor

comment:3

Looks good to me.

Merged in 4.0.rc2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants