Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[with patch and package] bug in symbolic arithmetic with exp #6256

Closed
burcin opened this issue Jun 10, 2009 · 7 comments
Closed

[with patch and package] bug in symbolic arithmetic with exp #6256

burcin opened this issue Jun 10, 2009 · 7 comments

Comments

@burcin
Copy link

burcin commented Jun 10, 2009

sage: var('kappa')
kappa
sage: x = sqrt(kappa)
sage: F = exp(x)
sage: F
e^sqrt(kappa)
sage: F/F
e^(2*sqrt(kappa))
sage: 1/F
e^(-sqrt(kappa))
sage: (1/F) * F
e^(2*sqrt(kappa))

CC: @jasongrout

Component: symbolics

Author: Burcin Erocal

Reviewer: Nick Alexander

Merged: 4.0.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6256

@burcin burcin added this to the sage-4.0.2 milestone Jun 10, 2009
@burcin burcin self-assigned this Jun 10, 2009
@burcin
Copy link
Author

burcin commented Jun 13, 2009

comment:1

Here is the fix for pynac:

diff --git a/ginac/mul.cpp b/ginac/mul.cpp
--- a/ginac/mul.cpp
+++ b/ginac/mul.cpp
@@ -1167,7 +1167,7 @@
        if (cmpval != 0) {
                return cmpval;
        }
-       if (seq.size() == 1 && overall_coeff.is_equal(_ex_1))
+       if (seq.size() == 1 && overall_coeff.is_equal(_ex1))
                return 0;
        return 1;
 }

I'll post an updated spkg later together with a fix for #6244.

@burcin
Copy link
Author

burcin commented Jun 14, 2009

Attachment: trac_6256-pynac_mul_compare_tests.patch.gz

doctests

@burcin
Copy link
Author

burcin commented Jun 14, 2009

comment:2

New pynac package fixes this:

http://sage.math.washington.edu/home/burcin/pynac/pynac-0.1.8.p0.spkg

It also contains fixes for #6244 and #6211, so doctests should be run with patches from those tickets applied.

Jason, can you review this?

@burcin burcin changed the title bug in symbolic arithmetic with exp [with patch and package] bug in symbolic arithmetic with exp Jun 14, 2009
@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Jun 14, 2009

Reviewer: Nick Alexander

@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Jun 14, 2009

comment:3

Fine by me, works with new spkg.

@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Jun 14, 2009

Merged: 4.0.2.alpha0

@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Jun 14, 2009

Author: Burcin Erocal

@ncalexan ncalexan mannequin closed this as completed Jun 14, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant