Typesettings of real() and imag() are broken

[golam-m-hossain]

Typesetting of real() and imag() methods are broken due to missing parenthesis.

sage: latex(x.real())
\Rex

"\Rex" is not a valid latex expression. It should be something
like "\Re\left(x\right)".

Similar issues are present also for Symbolic functions

sage: f(x) = function('f',x)
sage: latex( f(x).imag())
\Imf\left(x\right)

Again it should be similar to "\Im\left(f\left(x\right)\right)".

Component: symbolics

Author: Burcin Erocal

Reviewer: Golam Mortuza Hossain

Merged: Sage 4.1.1.rc1

Issue created by migration from https://trac.sagemath.org/ticket/6401

[burcin]

Attachment: trac_6401-real_imag_typesetting.patch.gz

doctest fixes for typesetting changes in pynac

[burcin]

comment:1

I have a fix for this in my local pynac tree. I will make a new package with a few more bugfixes available soon.

[burcin]

Author: Burcin Erocal

[burcin]

comment:2

This now depends on the package linked from #6404.

Please follow the instructions on that ticket to apply & test.

[golam-m-hossain]

comment:3

Hi Burcin,

I am testing out the new pynac spkg. Seems alright to me so far. Out of curiosity: is there
any reason to print the extra spaces around the the argument of real() and imag()?

sage: latex(real(x))
\Re \left( x \right)

Given it differs a bit from your earlier convention for default typesetting of
symbolic function

sage: psi(x) = function('psi',x)
sage: latex(psi(x))
\psi\left(x\right)

Otherwise, I am ready to give positive review as the output is valid latex expression in
both cases.

[burcin]

comment:4

There is no specific reason I chose that format. We can change it in the future if we decide on a convention.

[golam-m-hossain]

Reviewer: Golam Mortuza Hossain

[golam-m-hossain]

comment:5

Note: I am giving partial positive review because I tested this patch against my stable sage-4.1. So if it applies cleanly on Sage-4.1.1.rc1 then that would be full positive from me.

[sagetrac-mvngu]

comment:6

I applied patches in the following order:

1. the spkg pynac-0.1.8.p2.spkg at Typeseting for conjugate() of symbolic function is inadequate #6404
2. trac_6404-conjugate_typesetting.patch
3. trac_6401-real_imag_typesetting.patch
4. trac_6377-exp_infinity.patch
5. trac_6243-fderivative_hash.patch
   All doctests pass in my merge tree. So I'm changing Typeseting for conjugate() of symbolic function is inadequate #6404, Typesettings of real() and imag() are broken #6401, exp(x) is broken at x=Infinity and x=-Infinity #6377 and hashes for derivatives of symbolic functions w.r.t. different variables are the same #6243 to positive review as per Golam's request.

[sagetrac-mvngu]

Merged: Sage 4.1.1.rc1