New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permutation Group improvements #6647
Comments
Attachment: trac_6647_permutationgroup_improvement.patch.gz |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:4
This is a nice addition. I have a question though. In the docstring for a transversal, you have |
comment:5
Hello wdj, This is one piece i need for strong generating system thus generate integer vector up to action of a permgroup thus invariant theory of multivariate polynomials. The road will be long... My English is pretty horrible. You're definitely right. I don't really know in which order place my words and that can change the meaning. Here I Think the transversals as Representative of the quotient G/G_{integer} where G_{integer} = subgroup of G which stabilize integer. The reviewer have to feel free of correcting, susgesting improvement and hiting me for my mistakes. |
comment:7
Replying to @sagetrac-nborie:
I would replace However, if this is to be reviewed by applying 6620 and then this patch, I can tell you that I had a problem |
Changed keywords from permutationgroup, orbit, stabilizer, transversal to permutationgroup, orbit, stabilizer, transversal, strong generating system |
This comment has been minimized.
This comment has been minimized.
comment:8
Add a strong generating system method. I really need this method and so, this first implementation is not very good. The data structure (list of list) is dense and perhaps not very adapted (the python list begin at zero and the structure should be in correlation with positions and integer...(Dictionary? , family?, ...) ). This is really not optimized (I am waiting for LinGap...). If it goes in Sage as a first version, one could easily improve it... Comments, corrections, suggestions welcome! Wdj : What kind of problem ? Is it a problem of export ? ... On the sage-combinat queue, the two patch work well... |
comment:9
Replying to @sagetrac-nborie:
...
I've forgotten now the exact problem. I guess hg_sage.apply did not work for me. What does "the sage-combinat queue" mean? Does sage-combinat have their own trac system? |
comment:10
We just work with in special branch with a special mercurial queue I think... (the system is so complicated...)
hg = hg_sage in my shell I never use hg apply in fact as I work every times with the shared combinat branch and repository... |
comment:11
I fix a problem : any stabilizer must have the same degree of the permgroup in argument. I hardcoded that because I don't know how to do that in a better way... |
comment:12
I wonder if this patch was been submitted to the wrong trac system. I guess what the author is saying in some comments above is that the patch is to be applied to the sage-combinat version of sage, not the "standard" version. If that is correct, then either the patch should be submitted t the sage-combinat trac or rebased for the "standard" version. If that is not correct, then a better explanation of why it does not apply to the "standard" sage could be helpful. |
comment:13
I am very sorry for all the misunderstanding I produce... I think there is only one trac and only one sage. Franco or Nicolas (Thiéry) could say that better than me but i think we work with a special repository but we try to say the closer we can to the real sage version. I think that is my fault and and should try to work with different version of sage on my computer. I really should based that for the standard version... I really think there is only one way to go in sage (the trac, the only...). Sorry and thank for your comments. I continue my formation on sage... |
comment:14
I installed a new sage 4.1 and applyed only #6620 and #6647... It seems to work for me.
I must disturb the combinat guys too because the combinat wiki don't say how to interface from combinat patches to trac patches. If someone can tell me how it would normally work... |
comment:15
This still doesn't work for me. I don't understand the problem. On 4.1.alpha3, I ran
This worked fine. Then I ran
but this did not apply and instead opened up vi. I aborted the patch, since I didn't know what else to do. |
comment:16
I hope it will be Ok now. Jason Bandlow noticed that hg informations was missing in my patches. Beginner mystake : I did not export my patches (hg export) but just upload the files from .hg/patches to the trac. Sorry for that... |
comment:17
This (and the dependency #6620) applied fine to 4.1.1.rc2, on an intel macbook running 10.4.11. Although sage -testall gave
I think these are unrelated (and known) failures. Docstrings look good. Positive review from me. Are there other tests (eg, other platforms) needed to run before changing :needs" to "positive"? |
Attachment: trac_6647-reviewer.patch.gz reviewer patch; fix ReST formatting typos |
comment:19
The patch
|
comment:20
The reviewer ReST fixes seems good to me. Thanks for fix it. As I don't manage the trac when review over review appear, I leave another people change the status to positive... |
Reviewer: David Joyner, Minh Van Nguyen |
Merged: Sage 4.1.2.alpha0 |
Changed author from nborie to Nicolas Borie |
comment:22
Merged patches in this order:
|
comment:24
This may have caused a doctest failure -- see #7206. |
Add transversals, orbit, stabilizer and strong generating system methods for PermutationGroup.
depends on #6620
CC: @sagetrac-sage-combinat
Component: group theory
Keywords: permutationgroup, orbit, stabilizer, transversal, strong generating system
Author: Nicolas Borie
Reviewer: David Joyner, Minh Van Nguyen
Merged: Sage 4.1.2.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/6647
The text was updated successfully, but these errors were encountered: