New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complex_plot needs to use fast_callable #6985
Comments
comment:2
Do this and/or #6947 address the issues with complex_plot not plotting some functions it should? E.g. http://groups.google.com/group/sage-support/browse_thread/thread/c2cfabe10550cffe or http://groups.google.com/group/sage-devel/browse_thread/thread/a1a2b04747dbd0aa. |
Attachment: trac_6985.patch.gz |
comment:3
It fixes those issues, but not directly. In setup_for_eval_on_grid, we should check for not just types.FunctionType, but instead for (types.FunctionType, types.LambdaType, types.BuiltinFunctionType, types.BuiltinMethodType). Also, everything should be converted from fast_float to fast_callable. This would be a separate ticket. |
Author: Mike Hansen |
comment:4
Replying to @mwhansen:
Can you make another ticket for this? |
comment:5
There seems to be a regression: Note:
So maybe the fast_callable in the patch should use domain CDF! (this seems really odd to me, but I can't argue with the timings above!) |
comment:6
In fact, we see the same sort of speedup just with exp(x):
|
comment:7
The fast_callable documentation mentions a special interpreter for float, which is the same as for RDF, and also a special interpreter for CDF. It never mentions complex. So maybe that's a bug/feature request for fast_callable... |
comment:8
My simple patch to make the domain CDF should also maybe be reviewed. All of the plots are even faster now than with domain=complex. |
comment:9
For the tour: BEFORE PATCH:
AFTER PATCH:
|
comment:10
(oh, and positive review to mhansen's patch. My patch should still be reviewed.) |
comment:11
These don't apply for me properly - I don't have the stuff after the Riemann Zeta function and options, but before the actual code, e.g.
Is that in some other patch, or was it removed before 4.1.2.alpha2? |
Reviewer: Jason Grout, Karl-Dieter Crisman |
comment:12
Oh, and I think there should still be at least one example of the type
to show that it is still possible. |
comment:13
Oh, this patch depends on #6947. |
comment:14
Some work needs to be done on fast_callable to make it be able to replace fast_float: see #5572. |
comment:15
Does this mean this patch is not ready for review? I was going to try to review it (after applying #6947) later on... unfortunately, my main computer is on the fritz so it's back to 1 GB of memory and recompiling 4.1.2.alpha2 from scratch. |
comment:16
Nope, this patch is ready to go in (maybe after you add a patch with the doctest you like :). |
Attachment: trac-6985-CDF-domain.patch.gz apply on top of previous patch |
comment:17
I just updated the patch to have your example there too. |
Changed author from Mike Hansen to Mike Hansen, Jason Grout |
Apply on top of first patch, instead of other CDF patch |
comment:19
Attachment: trac_6985-CDF_and_reviewer.patch.gz Okay, positive review. I put the example I wanted under tests instead, because it's really noticeably slower. |
comment:20
Of course, this will unfortunately necessitate a one-line change in the patch for #7008 so it applies properly. |
comment:21
Merged patches in this order:
|
Merged: Sage 4.1.2.alpha3 |
Changed merged from Sage 4.1.2.alpha3 to Sage 4.1.2.alpha4 |
comment:22
There is no 4.1.2.alpha3. Sage 4.1.2.alpha3 was William Stein's release for working on making the notebook a standalone package. |
Timing differences:
CC: @kcrisman
Component: graphics
Author: Mike Hansen, Jason Grout
Reviewer: Jason Grout, Karl-Dieter Crisman
Merged: Sage 4.1.2.alpha4
Issue created by migration from https://trac.sagemath.org/ticket/6985
The text was updated successfully, but these errors were encountered: