Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial: delete the graph theory section #7149

Closed
jhpalmieri opened this issue Oct 8, 2009 · 5 comments
Closed

tutorial: delete the graph theory section #7149

jhpalmieri opened this issue Oct 8, 2009 · 5 comments

Comments

@jhpalmieri
Copy link
Member

From sage-devel:

As of version 4.1.2.alpha2, the Sage tutorial has a section containing 
a guided tour of graph theory in Sage.  In principle, this is a good 
idea, but the execution is severely flawed: about 2/3 of the tour 
focuses on the methods "g.max_matching()", "g.edge_coloring()", and 
"g.vertex_coloring()".  There are no such methods in Sage.  (The 
relevant doctests were never executed because of the issue discussed 
at trac ticket #6572.)  Since the tutorial ought to be one of the 
first pieces of documentation people use, this situation is 
disastrous. 

I suggest that before we release 4.1.2, we delete this part of the 
tutorial until the file is fixed.  (Alternatively, we could delete 2/3 
of the file, but that might make it a bit short on substance.) 

See #6572 for some related issues.

Component: documentation

Author: John Palmieri

Reviewer: Jason Grout

Merged: sage-4.1.2.rc1

Issue created by migration from https://trac.sagemath.org/ticket/7149

@williamstein
Copy link
Contributor

comment:1

Attachment: trac_7149-delete-graphtheory.patch.gz

thanks for noticing this!

merged in 4.2.1.rc1

@jasongrout
Copy link
Member

comment:2

This was from #6774. I gave it a positive review, pending the merging of the tickets with the necessary functionality, since I did not have those tickets merged in my tree yet. Minh merged it after the doctests passed (I guess assuming that the functions had been merged then), so it does look like it was a problem of the doctests not actually being run (manually or otherwise!).

Thanks for catching this; sorry for the bother!

We should probably reopen #6774 now, for when the functionality is merged into Sage.

@jhpalmieri
Copy link
Member Author

comment:3

We can reopen #6774 or open a new ticket -- I'm not sure which is better. In any case, we should make sure that the most recent version of the graph theory tour is included (combining at least #6774 and #6952 -- are there any other relevant tickets?).

@mwhansen
Copy link
Contributor

Merged: sage-4.1.2.rc1

@mwhansen
Copy link
Contributor

Reviewer: Jason Grout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants