neighbors_out/in instead of predecessor/successor in DiGraph

[nathanncohen]

This patch replaces the names successors/iterators by neighbors_in and neighbors_out.

THIS PATCH DEPENDS ON #7515 !!!!

CC: @jasongrout @rlmill @nthiery

Component: graph theory

Author: Nathann Cohen

Reviewer: Florent Hivert, Mike Hansen

Merged: sage-4.3.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/7157

[nathanncohen]

comment:1

On my side, it passes -testall without any (related) failure.

[rlmill]

comment:2

You shouldn't just remove the successor/predecessor terminology. A lot of people (e.g. Chris Godsil) might have to do a lot of work to change all their personal scripts etc. to reflect this change. This patch breaks backwards compatibility.

[nathanncohen]

comment:3

Should I just add aliases and let the old functions exist ? Should we keep two copies of the same functions ?

[rlmill]

comment:4

Replying to @nathanncohen:

Should I just add aliases and let the old functions exist ? Should we keep two copies of the same functions ?

I think aliases would be okay, but people have mentioned before that aliases are bad. Please bring this up on the sage-devel thread, and do what the consensus is there.

[nathanncohen]

comment:5

Should be better now :-)

The new functions are defined, old functions are marked "Deprecated".

[hivert]

comment:6

Hi there,

Just a short remark: If you wan't to shorten the patch: see #7515.

[nathanncohen]

comment:7

Thank you very much !!! :-)

[nathanncohen]

comment:8

Updated !

[hivert]

comment:9

Attachment: trac_7157.patch.gz

Replying to @nathanncohen:

Updated !

It was decided on sage-devel only to put the version and not the date in the message of deprecation aliases. I just uploaded a patch witch does that. Please review. Aside from that

You have a Positive review on trac_7157.patch. You can change the status as soon as you had an eye on my trivial review patch.

Cheers,

Florent

By the way a review on #7515 is welcome ;-)

[mwhansen]

Author: Nathann Cohen

[mwhansen]

Reviewer: Florent Hivert, Mike Hansen

[mwhansen]

Merged: sage-4.3.alpha1

[mwhansen]

comment:11

Attachment: trac_7157_review.patch.gz

I've added a new trac_7157_review.patch patch with two function calls that were missed.

[nathanncohen]

comment:12

Thank you ! :-)