Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make integrate accept a variable range as a tuple #7327

Closed
jasongrout opened this issue Oct 28, 2009 · 10 comments
Closed

Make integrate accept a variable range as a tuple #7327

jasongrout opened this issue Oct 28, 2009 · 10 comments

Comments

@jasongrout
Copy link
Member

It is inconsistent with plot and other functions that this just hangs:

integrate(sin(x), (x,0,1))

This patch takes care of this.

CC: @kcrisman

Component: calculus

Author: Jason Grout, Karl-Dieter Crisman

Reviewer: Karl-Dieter Crisman, Jason Grout, Mike Hansen

Merged: sage-4.2.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7327

@jasongrout
Copy link
Member Author

Attachment: trac-7327-integrate-range.patch.gz

@kcrisman
Copy link
Member

comment:1

This is a duplicate of #6816. The tests for one of these should be incorporated in the other - probably in this one, since it has some doc upgrades - and probably also the check for too many arguments in the tuple.

@kcrisman
Copy link
Member

kcrisman commented Nov 5, 2009

Based on Sage 4.2

@kcrisman
Copy link
Member

kcrisman commented Nov 5, 2009

comment:2

Attachment: trac_7327-updated.patch.gz

Updated patch includes the issues mentioned in previous comment, is ready for review. Positive review to the parts I didn't write.

@kcrisman
Copy link
Member

kcrisman commented Nov 5, 2009

Reviewer: Karl-Dieter Crisman, Jason Grout

@kcrisman
Copy link
Member

kcrisman commented Nov 5, 2009

Changed author from Jason Grout to Jason Grout, Karl-Dieter Crisman

@mwhansen
Copy link
Contributor

mwhansen commented Nov 6, 2009

comment:3

Looks good to me.

@mwhansen
Copy link
Contributor

mwhansen commented Nov 6, 2009

Changed reviewer from Karl-Dieter Crisman, Jason Grout to Karl-Dieter Crisman, Jason Grout, Mike Hansen

@mwhansen
Copy link
Contributor

mwhansen commented Nov 6, 2009

Merged: sage-4.2.1.alpha0

@kcrisman
Copy link
Member

comment:5

Just an update - it turns out the original integral reported in #6816 is not, in fact, convergent. Fixing this doctest so something mathematically correct happens will be done in #7745, since Maxima 5.20.1 simply returns that integral now, as opposed to giving 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants