Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display as much of a worksheet's title for which there's room #7404

Closed
qed777 mannequin opened this issue Nov 6, 2009 · 8 comments
Closed

Display as much of a worksheet's title for which there's room #7404

qed777 mannequin opened this issue Nov 6, 2009 · 8 comments

Comments

@qed777
Copy link
Mannequin

qed777 mannequin commented Nov 6, 2009

From sage-devel:

Jason Grout wrote:
> William Stein wrote:
>> Alex Ghitza wrote:
>>> 3. long worksheet titles get cut off even if there would be enough
>>> room to display them in their entirety (in my case, I had "Victorian
>>> Algebra Conference 2009" which appeared as "Victorian Algebra
>>> Conference 2...")

>> True.  It is tricky because fonts are proportionally spaced.

> Why does that make it tricky?  Make the div/table cell the maximum width
> possible (and expand as the browser window expands), and let the browser
> worry about when to cut off the text by setting the CSS style to chop
> off the text.  I suppose we'll miss the "..."; is that the tricky part? 

CC: @jasongrout @TimDumol @williamstein @kcrisman

Component: notebook

Author: Mitesh Patel

Issue created by migration from https://trac.sagemath.org/ticket/7404

@qed777 qed777 mannequin added c: user interface labels Nov 6, 2009
@qed777 qed777 mannequin assigned boothby Nov 6, 2009
@qed777
Copy link
Mannequin Author

qed777 mannequin commented Nov 6, 2009

A first take that probably overdoes it. Apply to sagenb repo.

@qed777
Copy link
Mannequin Author

qed777 mannequin commented Nov 6, 2009

comment:1

Attachment: trac_7404-css_worksheet_title.patch.gz

The first take appears to work, although a very long title is visible under and beyond the "Save/Discard" buttons.

I'm sure this is just one way to [attempt to] do it --- I'm not a CSS expert. Please feel to free to replace it. Either way, we should check that a candidate works in IE.

By the way, this patch may depend on other recent sagenb patches. Here's my current queue (ignore the version numbers):

trac_7316-sageinspect_defn.patch
trac_7318-sphinxify_confdir.patch
trac_7309-javascript-sage_v2.patch
trac_7310-modals.6.patch
trac_7332-css-escape.2.patch
trac_sagenb-7341.patch                          # Tab completion.
trac_sagenb-7346.patch                          # Vertical scrollbars.
trac_7339-sagenb_cell_bugs.patch
trac_7343-selenium-tests.4.patch
trac_7390-sagenb_test_report_A.patch
trac_7390-sagenb_test_report_B.patch
trac_7404-css_worksheet_title.patch             # This ticket!
trac_7385-renaming-published-worksheets.patch
trac_7384-sphinxify-docstrings.patch
trac_7354-jsmath_undo_revision.patch
trac_7322-jsmath_upgrade.patch
trac_7106-paren_match_doc.patch

But it's likely that several of these commute.

@qed777 qed777 mannequin added the s: needs review label Nov 6, 2009
@qed777
Copy link
Mannequin Author

qed777 mannequin commented Nov 11, 2009

comment:2

Replying to [comment:3:ticket6939 kcrisman]:

Sweet. I love CSS.

@qed777
Copy link
Mannequin Author

qed777 mannequin commented Nov 11, 2009

comment:3

Replying to @qed777:

Replying to kcrisman:

Sweet. I love CSS.

That's from this comment, by the way.

@kcrisman
Copy link
Member

comment:4

I should point out that I only love CSS, but am (also) not by any means an expert in it. Sorry.

@williamstein
Copy link
Contributor

comment:5

REFEREE REPORT:

(1) Looking at and reading the code -- it looks good.

(2) You should always set a milestone for the ticket. It helps a lot in keeping tickets from getting totally lost.

(3) This patch makes all the worksheet titles in the homescreen vanish, so that's a serious bug. See http://wstein.org/home/wstein/tmp/7404-a.png

(4) This patch also makes the top bar area look ridiculous (in my opinion) when the title is really long. See http://wstein.org/home/wstein/tmp/7404-b.png

@qed777
Copy link
Mannequin Author

qed777 mannequin commented Nov 25, 2009

comment:6

A [related] possibility: Use tablesorter to sort in the browser.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@boothby
Copy link

boothby commented Mar 29, 2020

comment:11

Closing deprecated notebook tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants