New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optional spkg nauty-24b7.p1 fails to build with sage-4.2.1 and ubuntu 9.10 (gcc-4.4.1) #7439
Comments
comment:1
|
comment:2
Using sage 4.3.4.alpha1 on Solaris 10 (SPARC) and don't even get as far as you do on Ununta. Instead I get problems with:
|
comment:3
http://dcsmail.anu.edu.au/pipermail/nauty-list/2009-November/000546.html shows Brendan's reply to Jason as well as possible work-arounds. Using -ansi did not work reporting same problem if put in CFLAGS and gave other errors (below) if put in CC definition:
however, his other suggestion, did make a compile work:
I'm not sure how to test that this doesn't brake anything within sage though. |
Upstream: Workaround found; Bug reported upstream. |
comment:4
In a personal email from Brendan McKay (author): Version 2.5 has some serious changes and won't be released for a while. An alternative to changing multiple files would be to insert
into nauty-h.in . |
Author: Paul Zimmermann |
comment:5
I confirm the following works (tried with sage-4.4.1 and nauty-24b7.p1.spkg):
Thanks to Brendan McKay for that patch. I have put an updated spkg at Paul |
comment:6
This spkg was horribly out of conformance with the current spkg guidelines. So I redid the spkg, upgraded to nauty 2.4 (final), and applied the above patch. The result is here: http://sage.math.washington.edu/home/jason/nauty-24.spkg Paul, could you in turn review the above spkg? It works for me on OSX 10.6 and Ubuntu 9.10. |
Reviewer: Jason Grout |
Changed author from Paul Zimmermann to Paul Zimmermann, Jason Grout |
Changed author from Paul Zimmermann, Jason Grout to Jason Grout |
comment:7
Jason, sorry for the horrible spkg, this was my first spkg... Your new spkg works like a charm
(I've removed my name as author since the new spkg is your work.) |
Changed reviewer from Jason Grout to Jason Grout, Paul Zimmermann |
comment:8
Replying to @zimmermann6:
Oh, I thought it was my fault, as I did the original nauty spkg, and there weren't nice guidelines back then.
Yes, but I don't know if there are any #optional doctests for nauty in the sage library. but the
Great! |
With gcc version 4.4.1 (Ubuntu 4.4.1-4ubuntu8):
Upstream: Workaround found; Bug reported upstream.
Component: packages: optional
Author: Jason Grout
Reviewer: Jason Grout, Paul Zimmermann
Issue created by migration from https://trac.sagemath.org/ticket/7439
The text was updated successfully, but these errors were encountered: