change plot to use fast_callable

[williamstein]

From this sage-support thread:

On Sun, Dec 6, 2009 at 4:51 PM, Michel <vdbergh@gmail.com> wrote:
> Thanks for the reply. But no. The problem is not due to the fact that
> the function has a singularity. Indeed.
>
> plot(20*log(abs((1+I*x)^4),10),(x,0,3))
>
> fails with the same error which is incomprehensible to me.
>
> On the other hand turning the expression into a lambda function made
> it possible to plot it. Thanks for this practical advice.
>
> I wish someone could explain this rationally to me.
>
> 20*log(abs((1+I*x)^4),10)
>
> seems to be a perfectly fine symbolic expression so IMHO it should be
> possible to plot it.

This is a bug.  There absolutely no reason that plotting should give the error
   "float() argument must be a string or a number".
We could give an error about not being able to evaluate the function at certain
points.  However, the above error is not OK.    The error in fact is not in plotting
but in making a fast_float compiled version of the expression:

sage: s = 20*log(abs((1+I*x)^4),10)
sage: fast_float(s,x)
Traceback (most recent call last):
...
TypeError: float() argument must be a string or a number

In fact, SAge *should* be using fast_callable, not fast_float.  This works
just fine if you force it manually:

s = 20*log(abs((1+I*x)^4),10)
plot(fast_callable(s,vars=[x]), (x,0,3))
[[nice picture as output]]

Many, many thanks for your bug report.  It is bug reports from users like
you that really helps Sage to be a first-rate mathematical software system.

Component: graphics

Author: William Stein

Reviewer: Jason Grout

Merged: sage-4.3.rc1

Issue created by migration from https://trac.sagemath.org/ticket/7614

[sagetrac-mvngu]

comment:1

From this sage-support thread:

On Sun, Dec 6, 2009 at 4:51 PM, Michel <vdbergh@gmail.com> wrote:
> Thanks for the reply. But no. The problem is not due to the fact that
> the function has a singularity. Indeed.
>
> plot(20*log(abs((1+I*x)^4),10),(x,0,3))
>
> fails with the same error which is incomprehensible to me.
>
> On the other hand turning the expression into a lambda function made
> it possible to plot it. Thanks for this practical advice.
>
> I wish someone could explain this rationally to me.
>
> 20*log(abs((1+I*x)^4),10)
>
> seems to be a perfectly fine symbolic expression so IMHO it should be
> possible to plot it.

This is a bug.  There absolutely no reason that plotting should give the error
   "float() argument must be a string or a number".
We could give an error about not being able to evaluate the function at certain
points.  However, the above error is not OK.    The error in fact is not in plotting
but in making a fast_float compiled version of the expression:

sage: s = 20*log(abs((1+I*x)^4),10)
sage: fast_float(s,x)
Traceback (most recent call last):
...
TypeError: float() argument must be a string or a number

In fact, SAge *should* be using fast_callable, not fast_float.  This works
just fine if you force it manually:

s = 20*log(abs((1+I*x)^4),10)
plot(fast_callable(s,vars=[x]), (x,0,3))
[[nice picture as output]]

Many, many thanks for your bug report.  It is bug reports from users like
you that really helps Sage to be a first-rate mathematical software system.

[jasongrout]

comment:3

Some of the things at #5572 need to be fixed (like constant functions) before this switch. Right now, fast_float handles things like constant functions, but fast_callable does not.

[williamstein]

comment:4

Replying to @jasongrout:

Some of the things at #5572 need to be fixed (like constant functions) before this switch. Right now, fast_float handles things like constant functions, but fast_callable does not.

1. fast_float is just as bad as fast_callable, IMHO, since fast_float fails to handle many things too.

2. Nobody is working on fast_callable, as far as I know, since Carl Witty is no longer working on Sage.

3. The specific problem under consideration could nicely by solved with a simple try/except:

try: 
    fast_float(...)
except:
    fast_callable(...)

[williamstein]

Attachment: trac_7614.patch.gz

[jasongrout]

comment:6

passes doctests, fixes the problem above.

[jasongrout]

Reviewer: Jason Grout

[jasongrout]

Author: William Stein

[mwhansen]

Merged: sage-4.3.rc1