Worksheet list CSS: Account for special characters in login names

[qed777]

We need to account for this difference

$ grep compile twist.py template.py
twist.py:re_valid_username = re.compile('[a-z|A-Z|0-9|_|.|@]*')
template.py:css_illegal_re = re.compile(r'[^-A-Za-z_0-9]')

when processing the checkboxes in a worksheet listing. Otherwise, the Archive, Stop, and Delete buttons will not work for users whose login names contain dots (.) or at signs (@).

This is a follow-up to #7332. See sage-devel for the bug report.

CC: @robert-marik @TimDumol @williamstein

Component: notebook

Author: Mitesh Patel

Reviewer: Robert Marik

Merged: sagenb-0.4.8

Issue created by migration from https://trac.sagemath.org/ticket/7811

[qed777]

Escape /, @, and . in worksheet list CSS IDs. sagenb repo.

[qed777]

Author: Mitesh Patel

[qed777]

comment:1

Attachment: trac_7811-escape_ws_list_ids.patch.gz

Please let me know if I've missed any other characters.

[TimDumol]

comment:2

Why not use /[^-A-Za-z_0-9]/g ? If the regexp for usernames is updated for all valid emails, then '+' will be allowed for usernames, which is illegal as a CSS id.

[qed777]

comment:3

Excellent point. I'll update the patch.

[qed777]

Attachment: trac_7811-escape_ws_list_ids_v2.patch.gz

More general RegExp. Replaces previous.

[robert-marik]

comment:4

Works for me. Is it neceassary to run ./sage -t even when upgrading spkg package?

[qed777]

comment:5

If you mean sage -b --- it's necessary only for changes to the main Sage library, under SAGE_ROOT/devel/sage, but not if you're just installing a spkg.

[TimDumol]

comment:6

Ideally this should be tested with sage -t -sagenb when #7650 comes in, or with a Selenium test (sagenb.testing), specifically in sagenb.testing.tests.test_accounts.

[robert-marik]

comment:7

Replying to @qed777:

If you mean sage -b --- it's necessary only for changes to the main Sage library, under SAGE_ROOT/devel/sage, but not if you're just installing a spkg.

No, I meant actually sage -t. I wondered, if I can give positive review without doctesting.

[robert-marik]

Reviewer: Robert Marik

[robert-marik]

comment:8

Wors fine. Tests passed. Doctests are not meaningful for this patch. Positive review.

[williamstein]

comment:9

merged into sagenb-0.4.8

[sagetrac-mvngu]

Merged: sagenb-0.4.8