Escape css id's and classes in templates

[TimDumol]

Currently, some css id's and classes have illegal values ('admin/0', for example, in worksheet_listing.html). This prevents jQuery and Selenium from accessing those attributes.

This adds a filter to produce legal values from those values.

CC: @williamstein @qed777

Component: notebook

Author: Tim Dumol

Reviewer: Mitesh Patel

Issue created by migration from https://trac.sagemath.org/ticket/7332

[TimDumol]

Attachment: trac_7332-css-escape.patch.gz

Adds css_escape filter and makes worksheet_listing.html use it.

[TimDumol]

Author: Tim Dumol

[TimDumol]

Fixed notebook_lib.js so that the checkboxes work after the patch.

[TimDumol]

comment:2

Attachment: trac_7332-css-escape.2.patch.gz

Deepends on #7310.

[qed777]

Attachment: trac_7332-css-escape.3.patch.gz

Also fix the overall checkbox ("controlbox"). Apply only this patch.

[qed777]

comment:3

Version 3:

• Rebased against SageNB -- Restructure /javascript/ to have /javascript/sage/ #7309, Use modal dialogs instead of javascript prompts for the rename prompt. #7310. For some reason, I got

applying trac_7332-css-escape.2.patch
patching file sagenb/notebook/template.py
Hunk #1 FAILED at 15
Hunk #3 FAILED at 75
2 out of 3 hunks FAILED -- saving rejects to file sagenb/notebook/template.py.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir

but the failures were inconsequential.

• Fixes the overall checkbox in notebook_lib.js.

To the extent it counts, my review is positive.

[qed777]

Reviewer: Mitesh Patel

[williamstein]

comment:4

Looks good to me.

[qed777]

comment:6

On this sage-devel thread: I forgot to account for dots ('.') in login names. A quick fix: In sagenb/data/sage/js/notebook_lib.js's check_worksheet_filenames, replace

        id = worksheet_filenames[i].replace('/', '-');

with

        id = worksheet_filenames[i].replace(/[\/.]/g, '-');

I'll open a new ticket and add a patch, once I'm confident I haven't missed other special characters.

[qed777]

comment:7

See #7811.