Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix indexing should be explained in the manual #7877

Closed
jasongrout opened this issue Jan 9, 2010 · 11 comments
Closed

matrix indexing should be explained in the manual #7877

jasongrout opened this issue Jan 9, 2010 · 11 comments

Comments

@jasongrout
Copy link
Member

A lot of the great stuff in the docstrings for the matrix __getitem__ and __setitem__ functions should be in the reference manual somewhere, maybe http://sagemath.org/doc/reference/sage/matrix/docs.html.

CC: @rbeezer @sagetrac-mvngu

Component: documentation

Author: Jason Grout

Reviewer: Robert Bradshaw, Minh Van Nguyen

Merged: sage-4.3.4.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7877

@jasongrout
Copy link
Member Author

comment:1

Attachment: trac-7877-doc-matrix-indexing.patch.gz

@jasongrout
Copy link
Member Author

Author: Jason Grout

@robertwb
Copy link
Contributor

comment:3

Depends on #8008, but otherwise, excellent!

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 20, 2010

Attachment: trac_7877-reviewer.patch.gz

apply on top of previous

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 20, 2010

Reviewer: Robert Bradshaw, Minh Van Nguyen

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 20, 2010

comment:5

Here's a typo in the patch:

96	Get the second column of M:: 
97	         
98	    sage: M[1:,0] 
99	    [ 1] 
100	    [ 1] 
101	    [-1]

The code should be:

sage: M[:,1]
[-2]
[ 8]
[ 1]
[ 2]

I have attached patch for this, which needs some review. Otherwise the whole ticket looks good.

@jasongrout
Copy link
Member Author

Attachment: trac-7877-doc-error.patch.gz

@jasongrout
Copy link
Member Author

comment:6

positive review for Minh's patch; I attached the same patch for the __getitem__ docstring in matrix0.pyx.

@jasongrout
Copy link
Member Author

comment:7

(apply trac-7877-doc-error.patch on top of all previous patches)

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Mar 2, 2010

Merged: sage-4.3.4.alpha0

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Mar 2, 2010

comment:8

Merged in this order:

  1. trac-7877-doc-matrix-indexing.patch
  2. trac_7877-reviewer.patch
  3. trac-7877-doc-error.patch

Jason: You should put a sensible commit message in your patch, together with the ticket number.

@sagetrac-mvngu sagetrac-mvngu mannequin removed the s: positive review label Mar 2, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Mar 2, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants