Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage -tp N should store times when some files fail #7941

Closed
rlmill mannequin opened this issue Jan 16, 2010 · 5 comments
Closed

sage -tp N should store times when some files fail #7941

rlmill mannequin opened this issue Jan 16, 2010 · 5 comments

Comments

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 16, 2010

line 364 of $SAGE_LOCAL/bin/sage-ptest is where to start looking:

    if len(failed) == 0:
        if interrupt == False:
            print "All tests passed!"
        else:
            print "Keyboard Interrupt: All tests that ran passed."
        #Only update timings if we are doing something standard
        if opts=="-long" or len(opts)==0:
            with open(time_file_name,"w") as time_file:
                pickle.dump(time_dict, time_file)
                print "Timings have been updated."
    else:
        if interrupt:
            print "Keyboard Interrupt, not all tests ran"
        print "\nThe following tests failed:\n"
        for i in range(len(failed)):
               print "\t", failed[i]
        print "-"*int(70)

The reason I want this is that if you're making lots of changes and testing frequently, and you never get a completely clean run, all the good files still run in a random order, which is inefficient.

Component: doctest coverage

Author: Robert Miller

Reviewer: Rob Beezer

Merged: sage-4.3.1.rc1

Issue created by migration from https://trac.sagemath.org/ticket/7941

@rlmill rlmill mannequin added this to the sage-4.3.1 milestone Jan 16, 2010
@rlmill rlmill mannequin added c: algebra labels Jan 16, 2010
@rlmill rlmill mannequin assigned aghitza Jan 16, 2010
@aghitza aghitza removed their assignment Jan 17, 2010
@rlmill
Copy link
Mannequin Author

rlmill mannequin commented Jan 18, 2010

Author: Robert Miller

@rlmill rlmill mannequin added the s: needs review label Jan 18, 2010
@rlmill
Copy link
Mannequin Author

rlmill mannequin commented Jan 19, 2010

Attachment: trac_7941.patch.gz

apply to scripts repo

@rbeezer
Copy link
Mannequin

rbeezer mannequin commented Jan 19, 2010

comment:3

Works as expected. Removed timings, introduced a doctest that would fail.

Ran sage -tp 2 -long devel/sage/sage/graphs/

twice, and repeated experiment without -long argument.

In both cases, second run obviously employed timings.

Positive review.

@rlmill
Copy link
Mannequin Author

rlmill mannequin commented Jan 19, 2010

Merged: sage-4.3.1.rc1

@rlmill
Copy link
Mannequin Author

rlmill mannequin commented Jan 19, 2010

Reviewer: Rob Beezer

@rlmill rlmill mannequin removed the s: positive review label Jan 19, 2010
@rlmill rlmill mannequin closed this as completed Jan 19, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant