Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot convert symbolic functions back from maxima #8345

Closed
burcin opened this issue Feb 24, 2010 · 8 comments
Closed

cannot convert symbolic functions back from maxima #8345

burcin opened this issue Feb 24, 2010 · 8 comments

Comments

@burcin
Copy link

burcin commented Feb 24, 2010

From sage-devel:

On Mon, 22 Feb 2010 07:02:21 -0800 (PST)
Håkan Granath <hakan.granath@googlemail.com> wrote:

> Typesetting conjugates of variables (that has been passed to
> Maxima and back?) is strange. In e.g. Sage 4.2 this did not
> happen.
> 
> ----------------------------------------------------------------------
> | Sage Version 4.3.3, Release Date: 2010-02-21                       |
> | Type notebook() for the GUI, and license() for information.        |
> ----------------------------------------------------------------------
> sage: assume(x,'complex')
> sage: latex(x.conjugate())
> \overline{x}
> sage: latex(x.conjugate().factor())
> {\rm conjugate}\left(x\right)

Somehow we don't recognize the conjugate function in the string we get back from maxima, and create a new one. The last line above is the default latex typesetting for symbolic functions.

The thread is here:

http://groups.google.com/group/sage-devel/t/cd43a14bee6e9be


Apply attachment: trac_8345-doctest.patch.

CC: @kcrisman

Component: interfaces

Author: Burcin Erocal

Reviewer: Karl-Dieter Crisman

Merged: sage-4.7.1.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/8345

@burcin
Copy link
Author

burcin commented Jun 1, 2011

comment:1

This seems to be fixed in the meanwhile. attachment: trac_8345-doctest.patch adds a doctest.

@burcin
Copy link
Author

burcin commented Jun 1, 2011

Author: Burcin Erocal

@kcrisman
Copy link
Member

kcrisman commented Jun 8, 2011

Reviewer: Karl-Dieter Crisman

@kcrisman
Copy link
Member

kcrisman commented Jun 8, 2011

comment:3

This patch does not apply to 4.7.1.alpha1 because of a blank line someone must have removed earlier. Unfortunately, I can't figure out how to fix the patch easily (so that Burcin remains the author of the patch), so it will have to be rebased. Hopefully that won't be too much trouble :(

This also exposes a different problem - that our variables are assumed to be real. This is known elsewhere.

sage: latex(x.conjugate())
\overline{x}
sage: latex(x.conjugate().simplify())
x

Not sure if that needs to be addressed on this ticket, though.

@burcin
Copy link
Author

burcin commented Jun 9, 2011

comment:4

Attachment: trac_8345-doctest.patch.gz

Replying to @kcrisman:

This patch does not apply to 4.7.1.alpha1 because of a blank line someone must have removed earlier. Unfortunately, I can't figure out how to fix the patch easily (so that Burcin remains the author of the patch), so it will have to be rebased. Hopefully that won't be too much trouble :(

I uploaded a rebased patch with the same name.

If you qimport a patch which already has mercurial headers, make changes, then qrefresh and export, the author shouldn't change. In this case, it wouldn't matter even if you changed it. :)

This also exposes a different problem - that our variables are assumed to be real. This is known elsewhere.

sage: latex(x.conjugate())
\overline{x}
sage: latex(x.conjugate().simplify())
x

Not sure if that needs to be addressed on this ticket, though.

That is #6882, well beyond the scope of this ticket.

@kcrisman
Copy link
Member

kcrisman commented Jun 9, 2011

comment:5

Okay, thanks - and thanks for the tip, in the last few months I've finally started using queues.

I already tried several things yesterday, so all is well. Positive review.

Incidentally, this has been fixed for a while:

----------------------------------------------------------------------
| Sage Version 4.4.4, Release Date: 2010-06-23                       |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
Loading Sage library. Current Mercurial branch is: hackbranch
sage: assume(x,'complex')
sage: latex(x.conjugate().simplify())
\overline{x}
sage: 

Apply attachment: trac_8345-doctest.patch.

@kcrisman

This comment has been minimized.

@jdemeyer
Copy link

Merged: sage-4.7.1.alpha4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants