Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

real_part? has an unescaped \r #8449

Closed
jasongrout opened this issue Mar 5, 2010 · 8 comments
Closed

real_part? has an unescaped \r #8449

jasongrout opened this issue Mar 5, 2010 · 8 comments
Assignees
@sagetrac-mvngu
Labels
c: documentation p: trivial / 5 t: bug
Milestone
sage-4.4.2

Comments

@jasongrout
Copy link
Member

This docstring should be a raw string (i.e., r""" ... """)

Component: documentation

Author: Minh Van Nguyen, Burcin Erocal

Reviewer: Burcin Erocal, Minh Van Nguyen

Merged: sage-4.4.2.rc0

Issue created by migration from https://trac.sagemath.org/ticket/8449
@jasongrout jasongrout added this to the sage-4.4.2 milestone Mar 5, 2010
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 9, 2010

Attachment: trac_8449.patch.gz

based on Sage 4.4.2.alpha0

@burcin
Copy link

burcin commented May 10, 2010

Attachment: trac_8449.more_rs.patch.gz

@burcin
Copy link

burcin commented May 10, 2010

comment:2

There were a few more docstrings in that file with the same problem. Positive review to Minh's patch. Someone needs to review mine now. :)

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 10, 2010

Reviewer: Burcin Erocal, Minh Van Nguyen

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 10, 2010

Author: Minh Van Nguyen, Burcin Erocal

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 10, 2010

comment:3

Looks good. Burcin's patch clearly takes care of the others I missed.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 11, 2010

comment:4

Merged in this order:

  1. trac_8449.patch
  2. trac_8449.more_rs.patch

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 11, 2010

Merged: sage-4.4.2.rc0

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed May 11, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-mvngu sagetrac-mvngu

Labels
c: documentation p: trivial / 5 t: bug
Projects
None yet
Milestone
sage-4.4.2
Development

No branches or pull requests
2 participants
@jasongrout @burcin