New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements cycle index for permutation groups, toward Polya enumeration #8549
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
This should allow to do some plethysm very easily. Suggestion welcome to improve the latex math line and make it more nice and understandable. |
comment:4
After face to face discussion, this patch is ready for review! |
Changed keywords from permutation, cycle, enumeration to permutation groups, cycle index, Polya enumeration |
Reviewer: Nicolas M. Thiéry, Nicolas Borie |
Author: Nicolas Borie, Nicolas M. Thiéry |
comment:6
If I apply "trac_8549_cycle_enumerator-nb.patch" on top of 4.4.alpha1, all tests pass. If I instead apply the patch from #8500, all tests pass. If I apply both patches, though, then I get a doctest failure:
|
comment:7
I'm sorry, I forgot to say that I've only seen this on a Mac (OS X 10.6.3). On sage.math, all tests pass. |
comment:8
Replying to @jhpalmieri:
#8500 and #8549 together pass all long tests on 64-bit Ubuntu 9.04. I also saw Mike Hansen at Sage Days 21 test just the file |
comment:9
Nicolas(s), This is a nice addition, and I can already think of a use for it in a classroom example. Some small comments/suggestions:
I would write the plural as "cycle indices." Nicely written otherwise.
(a) Do you want to add this into the reference manual? (b) Last doctest block needs a preceding "::" to make it render as verbatim. (c) Two instances of "cycle_type" near the top print weird due to the underscore. Important stuff: builds and passes long tests, works as advertised. So I'm ready to give this a positive review subject to the above minor items. Rob |
comment:10
See #8500 for the results of further OSX testing on this combination. |
Changed reviewer from Nicolas M. Thiéry, Nicolas Borie to Nicolas M. Thiéry, Nicolas Borie, Robert Beezer |
comment:11
Hi, I just wrote a quick patch in the queue implementing the requested changes, and adding FinitePermutationGroups to the ref manual where it was missing. Nicolas, please double check, fold, and reupload. |
comment:12
Attachment: trac_8549_cycle_enumerator-nb.patch.gz Thanks very much for these fix. All tests pass for sage, all tests long and optionnal pass for the finite_permutation_groups, the doc is well built... New comments for parent argument make also more clear the doc. Positive Review from me. Thanks you Rob for pointing improvements and fix. |
comment:14
I change two times the status of this patch but I precise the last change come from Nicolas Thiéry. This positive review is also modulo the comment
I currently have no possible access to any OS X machine. All my tests was computing from Ubuntu machines. |
Merged: sage-4.4.4.alpha0 |
Changed reviewer from Nicolas M. Thiéry, Nicolas Borie, Robert Beezer to Nicolas M. Thiéry, Nicolas Borie, Rob Beezer |
Let G a permutation group. Each permutation of G has a cycle type. The goal of this ticket is to add a method for permutation group which returns a symmetric function in the monomial symmetric functions whose terms are the numbers of permutation in G having the cycle type (Partition) indexing the corresponding monomial.
CC: @sagetrac-sage-combinat
Component: combinatorics
Keywords: permutation groups, cycle index, Polya enumeration
Author: Nicolas Borie, Nicolas M. Thiéry
Reviewer: Nicolas M. Thiéry, Nicolas Borie, Rob Beezer
Merged: sage-4.4.4.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/8549
The text was updated successfully, but these errors were encountered: