New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert RDF/CDF matrices to numpy #8719
Comments
Author: Jason Grout |
This comment has been minimized.
This comment has been minimized.
comment:5
rbeezer: it seems like you could naturally review this. It just adds a numpy-specific magic method for conversion. |
comment:6
Hi Jason, So you have defined a new method " If so, could you say so? The line So I'm suggesting maybe this seemingly circular arrrangement (modify Sage matrices, so numpy can deal with them, using a Sage function to convert to a numpy array) could be better explained so nobody messes it up or gets too confused. With the added code and the added doctests all together, I think I was able to figure this out - otherwise it would have been a head-scratcher. Rob |
Attachment: trac_8719-numpy-conversion.patch.gz |
comment:7
I updated the docs. |
comment:8
Replying to @jasongrout:
Looks good! I'll finish this tomorrow night. |
comment:9
Looks good, builds and passes all tests, documentation builds without warnings. The added documentation looks great. Positive review. |
Reviewer: Rob Beezer |
Merged: sage-4.4.2.alpha0 |
This patch makes the following work:
CC: @rbeezer
Component: linear algebra
Author: Jason Grout
Reviewer: Rob Beezer
Merged: sage-4.4.2.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/8719
The text was updated successfully, but these errors were encountered: