Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate version of feedback_arc_set and feedback_vertex_set #8798

Closed
nathanncohen mannequin opened this issue Apr 28, 2010 · 9 comments
Closed

Duplicate version of feedback_arc_set and feedback_vertex_set #8798

nathanncohen mannequin opened this issue Apr 28, 2010 · 9 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 28, 2010

Here is the problem :

~/sage/sage-doc/sage/graphs$ grep -e "def.*eedback" *
digraph.py:    def feedback_edge_set(self,value_only=False):
digraph.py:    def feedback_vertex_set(self,value_only=False):
generic_graph.py:    def feedback_edge_set(self,value_only=False):
generic_graph.py:    def feedback_vertex_set(self,value_only=False):
~/sage/sage-doc/sage/graphs$ 

Prerequisite: #8786

Apply:

CC: @sagetrac-mvngu

Component: graph theory

Author: Nathann Cohen

Reviewer: Minh Van Nguyen

Merged: sage-4.4.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8798

@nathanncohen nathanncohen mannequin added this to the sage-4.4.2 milestone Apr 28, 2010
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Apr 28, 2010

Attachment: trac_8798.patch.gz

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Apr 28, 2010

comment:1

And here is the patch ! This code would not work for undirected graphs anyway :-)

Nathann

@nathanncohen nathanncohen mannequin added the s: needs review label Apr 28, 2010
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Apr 28, 2010

Author: Nathann Cohen

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Apr 28, 2010

comment:2

Attachment: trac_8798-rebased.patch.gz

The patch trac_8798.patch is OK by me. However, it would likely conflict with #8786. So trac_8798-rebased.patch is a rebase of trac_8798.patch on top of #8786. Someone other than myself needs to check the rebased patch. If it's OK, then the whole ticket is good to go.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Apr 28, 2010

Reviewer: Minh Van Nguyen

@sagetrac-mvngu

This comment has been minimized.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Apr 29, 2010

comment:3

Checked ! Thank you for your help ! :-)

Nathann

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 8, 2010

Merged: sage-4.4.2.alpha0

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 8, 2010

comment:4

Merged trac_8798-rebased.patch.

@sagetrac-mvngu sagetrac-mvngu mannequin removed the s: positive review label May 8, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed May 8, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant