New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preparse vector-valued functions and derivatives #8866
Comments
comment:1
Right now, all the docs are wrong or missing for the added functionality. |
comment:2
I added docs for each functionality that changed. |
comment:3
make ptestlong appears to pass on 4.4.1 (ubuntu 64-bit). |
comment:4
I'm running tests right now. In the meantime, could this be less ugly? I realize that the naked '4's are not callable, so there is the deprecation warning, but the error warning seems severe.
I didn't know you could create a vector space of functions. Complete with a basis. ;-)
|
comment:5
Replying to @rbeezer:
That's stemming from this, of course:
I don't know what should be done about that to make it prettier. Usually you wouldn't "call" an integer by itself (as just a symbolic integer is not a function...) Note that making matrices callable is just extending the existing behavior for vectors.
Yes, interesting. That stems from callable expressions being just normal expressions with a bit of extra information (default variable order for calls). Of course, it gave you back a basis for symbolic expressions. |
comment:6
Replying to @jasongrout:
Me either. ;-) I guess I found it odd that there was a deprecation warning, then a failure. But maybe that's just the way it goes. |
comment:7
This all checks out fine: builds and runs, passes all tests, documentation is fine. So, positive review. |
same as previous but with ticket number in commit message |
comment:8
Attachment: trac-8866-preparse-vector-functions-derivatives.2.patch.gz |
Reviewer: Rob Beezer |
Merged: sage-4.4.2.alpha0 |
Here is a rough patch which enables the following:
CC: @mwhansen @burcin @kcrisman @rbeezer
Component: symbolics
Author: Jason Grout
Reviewer: Rob Beezer
Merged: sage-4.4.2.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/8866
The text was updated successfully, but these errors were encountered: