Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove p-adic matrix directory #9064

Closed
williamstein opened this issue May 27, 2010 · 6 comments
Closed

remove p-adic matrix directory #9064

williamstein opened this issue May 27, 2010 · 6 comments

Comments

@williamstein
Copy link
Contributor

There's a single file in matrix/padics and it is an empty init.py.

Says David Roe: "Yeah, oversight.  At some point I was planning on working on p-adic matrices, and I guess the init.py file got put in then.  Since I'm not going to work on it anytime soon, it can safely be removed."

Component: linear algebra

Author: William Stein

Reviewer: David Roe

Merged: sage-4.5.3.rc0

Issue created by migration from https://trac.sagemath.org/ticket/9064

@williamstein
Copy link
Contributor Author

comment:1

Since the file is empty, I can't do think of any way to actually do this with HG. It seems impossible.

flat:matrix wstein$ hg rm  padics
removing padics/__init__.py
flat:matrix wstein$ 
flat:matrix wstein$ 
flat:matrix wstein$ hg ci
flat:matrix wstein$ hg export ip
abort: unknown revision 'ip'!
flat:matrix wstein$ hg export tip
# HG changeset patch
# User William Stein <wstein@gmail.com>
# Date 1281549848 25200
# Node ID 029114d1f8a76cbd4d88b2a9a28fecadac170205
# Parent  5b338f2e484f2065d3d30d47bc204d6e9ed13d12
trac 9064 -- remove p-adic matrix directory

(see nothing!)

So there is no patch to post, and I take David Roe's statement (above) as a positive review.

So to the release manager merging this, just do the following:

cd SAGE_ROOT/devel/sage/sage/matrix
sage -hg rm  padics
sage -hg ci

and checkin the resulting empty patch. Unfortunately, this won't do anything for people doing "sage -upgrade". Anyway, it's an empty directory so whatever happens is pretty harmless.

@qed777
Copy link
Mannequin

qed777 mannequin commented Aug 15, 2010

Author: William Stein

@qed777
Copy link
Mannequin

qed777 mannequin commented Aug 15, 2010

Reviewer: David Roe

@qed777
Copy link
Mannequin

qed777 mannequin commented Aug 31, 2010

Remove matrix/padics.

@qed777
Copy link
Mannequin

qed777 mannequin commented Aug 31, 2010

comment:4

Attachment: trac_9064-remove_padic_matrix.patch.gz

Replying to @williamstein:

So there is no patch to post, and I take David Roe's statement (above) as a positive review.

I've attached a patch made with the Mercurial queues extension.

@qed777
Copy link
Mannequin

qed777 mannequin commented Aug 31, 2010

Merged: sage-4.5.3.rc0

@qed777 qed777 mannequin removed the s: positive review label Aug 31, 2010
@qed777 qed777 mannequin closed this as completed Aug 31, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants