New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSD.py doctest failure due to timeout of Heegner index computation. #9127
Comments
Author: Robert Miller |
Reviewer: John Cremona |
comment:4
This one confuses me. Before I apply the patch, the file passes long tests for me (ubuntu 64-bit, on 4.4.3). But after the patch it does not:
So whether or not the patch fixes things on some systems, it breaks others, so cannot be included. |
Attachment: trac_9127.patch.gz |
comment:6
The patch results in the test passing on the Sun Blade 1000 where the test originally failed.
I would be tempted to give it a positive review, though the fact John had a problem, it would be wise to wait and see if he has any further comments. But the changes look OK to me and it solves the problem. Dave |
Changed reviewer from John Cremona to John Cremona, David Kirkby |
comment:8
Once this issue is resolved (and it looks like it will be very soon), #8409 can be closed. Dave |
comment:9
Replying to @sagetrac-drkirkby:
I think all of the issues with this ticket have been resolved. |
comment:10
In which case, positive review. I'm happy with it. |
comment:11
I am happy. (I thought I had reviewed the new patch, but maybe I was dreaming!) |
Merged: sage-4.4.4.alpha1 |
This failure seems remarkably close to #8749, which is closed as fixed, but this is the same sort of problem on the same doctest. Note, changing SAGE_TIMOUT will not change this, as it appears (to me at least), Sage is switching from one algorithm to another in a time which is independent of the processor speed or settings of any timeout variables.
Hardware & associated software
== Sage version ==
== The test failure ==
A full log of all tests can be found at
http://boxen.math.washington.edu/home/kirkby/sage-4.4.3.alpha0-Sun-Blade-1000-900MHz-Solaris-10-ptestlong.log.gz
(There are 3 failures, but I believe the other two are common to more than one platform and work is progressing on them)
I would expect to see this fail the same way on 't2' as 't2' is slower on single threaded tasks than the Blade 1000.
CC: @robertwb @rlmill @williamstein @jhpalmieri
Component: elliptic curves
Author: Robert Miller
Reviewer: John Cremona, David Kirkby
Merged: sage-4.4.4.alpha1
Issue created by migration from https://trac.sagemath.org/ticket/9127
The text was updated successfully, but these errors were encountered: