Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSD: doctest failures on solaris (t2) #8749

Closed
jhpalmieri opened this issue Apr 23, 2010 · 9 comments
Closed

BSD: doctest failures on solaris (t2) #8749

jhpalmieri opened this issue Apr 23, 2010 · 9 comments

Comments

@jhpalmieri
Copy link
Member

With Sage 4.4.alpha2, I see the following:

File "/home/palmieri/t2/sage-4.4.alpha2/devel/sage-main/sage/schemes/elliptic_curves/BSD.py", line\
 304:
    sage: EllipticCurve('11a').prove_BSD(verbosity=2)
Expected:
    p = 2: True by 2-descent
    True for p not in {2, 5} by Kolyvagin.
    True for p=5 by Mazur
    []
Got:
    p = 2: True by 2-descent
    Timeout stopped Heegner index computation...
    Proceeding to use heegner_index_bound instead.
    True for p not in {2, 5} by Kolyvagin.
    True for p=5 by Mazur
    []
**********************************************************************
File "/home/palmieri/t2/sage-4.4.alpha2/devel/sage-main/sage/schemes/elliptic_curves/BSD.py", line\
 377:
    sage: E.prove_BSD(verbosity=2)               # long time
Exception raised:
    Traceback (most recent call last):
      File "/home/palmieri/t2/sage-4.4.alpha2/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/home/palmieri/t2/sage-4.4.alpha2/local/bin/sagedoctest.py", line 38, in run_one_examp\
le
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/home/palmieri/t2/sage-4.4.alpha2/local/bin/ncadoctest.py", line 1172, in run_one_exam\
ple
        compileflags, 1) in test.globs
      File "<doctest __main__.example_6[22]>", line 1, in <module>
        E.prove_BSD(verbosity=Integer(2))               # long time###line 377:
    sage: E.prove_BSD(verbosity=2)               # long time
      File "/home/palmieri/t2/sage-4.4.alpha2/local/lib/python/site-packages/sage/schemes/elliptic\
_curves/BSD.py", line 761, in prove_BSD
        raise RuntimeError("p = %d: ord_p_bound == %d, but sha_an.ord(p) == %d. This appears to be\
 a counterexample to BSD, but is more likely a bug."%(p,ord_p_bound,BSD.sha_an.ord(p)))
    RuntimeError: p = 3: ord_p_bound == 1, but sha_an.ord(p) == 2. This appears to be a counterexa\
mple to BSD, but is more likely a bug.
**********************************************************************
1 items had failures:
   2 of  35 in __main__.example_6
***Test Failed*** 2 failures.

The first is a timeout issue of some sort, and perhaps could be fixed by putting in some dots ... in case the timeout message appears. (I've also seen more failures of this type from the same file, so ellipses in several places might be needed. Test on t2 several times to see.)

I have no idea about the second issue. Presumably it's not a counterexample to BSD.

CC: @robertwb @rlmill

Component: elliptic curves

Author: Robert Miller

Reviewer: William Stein

Merged: sage-4.4.1.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/8749

@jhpalmieri
Copy link
Member Author

Replying to @jhpalmieri:

(I've also seen more failures of this type from the same file, so ellipses in several places might be needed. Test on t2 several times to see.)

More specifically, I just saw this on lines 304, 310, 336, and 418.

@jhpalmieri jhpalmieri modified the milestones: sage-5.0, sage-4.4.1 Apr 27, 2010
@rlmill
Copy link
Mannequin

rlmill mannequin commented Apr 30, 2010

comment:4

Attachment: trac_8749.patch.gz

@williamstein
Copy link
Contributor

Merged: 4.4.1.alpha3

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 1, 2010

Author: Robert Miller

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 1, 2010

Reviewer: William Stein

@williamstein
Copy link
Contributor

comment:8

It turns out this patch works on t2, but fails on everything else... due to misuse of ...
The attached patch fixes this by removing a newline in each ...'d test.

@rlmill
Copy link
Mannequin

rlmill mannequin commented May 1, 2010

comment:9

Attachment: trac_8749-part2.patch.gz

Second patch looks good: positive review.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 3, 2010

Changed merged from 4.4.1.alpha3 to sage-4.4.1.alpha3

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Jun 3, 2010

comment:11

I don't think this is fixed properly - or if it was, a very similar error is now occurring on the same doctest. See #9127

Dave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants