Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring doc coverage of groups/group.pyx to 100% #9216

Closed
seblabbe opened this issue Jun 11, 2010 · 7 comments
Closed

Bring doc coverage of groups/group.pyx to 100% #9216

seblabbe opened this issue Jun 11, 2010 · 7 comments
Assignees
@seblabbe
Labels
c: documentation p: major / 3 t: enhancement
Milestone
sage-4.5.2

Comments

@seblabbe
Copy link
Contributor

CC: @sagetrac-sage-combinat

Component: documentation

Author: Sébastien Labbé

Reviewer: Franco Saliola

Merged: sage-4.5.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/9216
@seblabbe seblabbe added this to the sage-4.5.2 milestone Jun 11, 2010
@seblabbe seblabbe self-assigned this Jun 11, 2010
@seblabbe
Copy link
Contributor Author

Attachment: trac_9216_doc_group_pyx-sl.patch.gz

@seblabbe
Copy link
Contributor Author

Author: Sébastien Labbé

@saliola
Copy link

saliola commented Jun 11, 2010

Reviewer: Franco Saliola

@saliola
Copy link

saliola commented Jun 11, 2010

comment:2

ok.

reviewed against 4.4.3.

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jul 6, 2010

comment:3

Perhaps you should have an example of __contains__ working, not just failing. Should just return true or false, right?

-- RLM, and the audience at SD 23.

@rlmill rlmill mannequin added s: needs work and removed s: positive review labels Jul 6, 2010
@williamstein
Copy link
Contributor

comment:4

Oops -- WJP just pointed out that I was wrong.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jul 21, 2010

Merged: sage-4.5.2.alpha0

@qed777 qed777 mannequin removed the s: positive review label Jul 21, 2010
@qed777 qed777 mannequin closed this as completed Jul 21, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seblabbe seblabbe

Labels
c: documentation p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-4.5.2
Development

No branches or pull requests
3 participants
@williamstein @seblabbe @saliola