Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete the (ridiculous) method __copy__ from matrix0.pyx #9239

Closed
williamstein opened this issue Jun 14, 2010 · 7 comments
Closed

delete the (ridiculous) method __copy__ from matrix0.pyx #9239

williamstein opened this issue Jun 14, 2010 · 7 comments
Assignees
@jasongrout @williamstein
Labels
c: linear algebra p: minor / 4 t: bug
Milestone
sage-4.5.2

Comments

@williamstein
Copy link
Contributor

__copy__ was overloaded, never used.

See this sage-devel thread for background information.

Component: linear algebra

Author: Florent Hivert

Reviewer: William Stein

Merged: sage-4.5.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/9239
@williamstein williamstein added this to the sage-4.5.2 milestone Jun 14, 2010
@hivert
Copy link

hivert commented Jun 15, 2010

Author: Florent Hivert

@hivert

This comment has been minimized.

Sign in to view
@hivert
Copy link

hivert commented Jun 15, 2010

comment:1

Attachment: trac_9239-matrix_copy_remove-fh.patch.gz

Note: the doctest where duplicated from the .copy() method so I didn't kept them.

Please review

@williamstein
Copy link
Contributor Author

comment:2

Yep.

@sagetrac-mvngu

This comment has been minimized.

Sign in to view
@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jun 29, 2010

Reviewer: William Stein

@qed777
Copy link
Mannequin

qed777 mannequin commented Jul 20, 2010

Merged: sage-4.5.2.alpha0

@qed777 qed777 mannequin removed the s: positive review label Jul 20, 2010
@qed777 qed777 mannequin closed this as completed Jul 20, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasongrout jasongrout

@williamstein williamstein

Labels
c: linear algebra p: minor / 4 t: bug
Projects
None yet
Milestone
sage-4.5.2
Development

No branches or pull requests
3 participants
@jasongrout @williamstein @hivert