Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong LP solver ordering #9570

Closed
nathanncohen mannequin opened this issue Jul 22, 2010 · 9 comments
Closed

Wrong LP solver ordering #9570

nathanncohen mannequin opened this issue Jul 22, 2010 · 9 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jul 22, 2010

At the moment, GLPK is the solver used regardless of the presence of CBC or CPLEX. This is just because of a line written ten lines too high in the file !

Nathann

Component: numerical

Author: Nathann Cohen, Leonardo Sampaio

Reviewer: Nathann Cohen, Leonardo Sampaio

Merged: sage-4.5.2.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/9570

@nathanncohen nathanncohen mannequin added this to the sage-4.5.2 milestone Jul 22, 2010
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 22, 2010

comment:1

Attachment: trac_9570.patch.gz

@nathanncohen nathanncohen mannequin added the s: needs review label Jul 22, 2010
@sagetrac-lsampaio
Copy link
Mannequin

sagetrac-lsampaio mannequin commented Jul 23, 2010

Fixes the AttributeError that was returned when no mip solver was specified by the user

@sagetrac-lsampaio
Copy link
Mannequin

sagetrac-lsampaio mannequin commented Jul 23, 2010

comment:2

Attachment: trac_9570-fix.patch.gz

I applied your patch, but while trying to solve an MIP without specifying a solver, I've got an AttributeError, since the attribute '_default_solver' was not defined.
I just fixed this by adding a line stating that _default_solver = None.
If you agree with my changes, I think the patch can be said to be reviwed.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 23, 2010

comment:3

Excellent ! Thank you very much for your help :-)

Both apply fine and in the end, it works... Now the annoying part is #8880 because CPLEX is called by next-to-any method in the LP library XD

Nathann

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 23, 2010

Author: Nathann Cohen, Leonardo Sampaio

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 23, 2010

Reviewer: Nathann Cohen, Leonardo Sampaio

@dandrake
Copy link
Contributor

Merged: sage-4.5.2.alpha1

@dandrake
Copy link
Contributor

comment:4

Leonardo -- be sure to use informative commit messages for your patches. "fix" is not very helpful. :) Always include a ticket number, too. I changed your commit message to "ticket 9570: insure _default_solver attribute exists".

both patches merged in 4.5.2.alpha1.

@sagetrac-lsampaio
Copy link
Mannequin

sagetrac-lsampaio mannequin commented Jul 26, 2010

comment:5

ok, thanks for the advice =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants