SageNB 0.8.2

[qed777]

New spkg here:

http://sage.math.washington.edu/home/mpatel/trac/9572/sagenb-0.8.2.spkg

Merged in SageNB 0.8.2: #3342, #9554, #9580.

CC: @sagetrac-acleone @nexttime @TimDumol

Component: notebook

Author: Mitesh Patel

Reviewer: Carl Witty

Merged: sage-4.5.2.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/9572

[dandrake]

comment:1

You might consider #8574 and #9512, which are both positively reviewed.

[dandrake]

comment:2

Replying to @dandrake:

You might consider #8574 and #9512, which are both positively reviewed.

Er, I mean, #8754.

[qed777]

Author: Mitesh Patel

[qed777]

comment:3

All long doctests pass for me on sage.math with 4.5.2.alpha0 + sagenb-0.8.2.spkg. But given my current computer setup, I can't run the Selenium tests.

[nexttime]

comment:4

Remember to do #9580 comment:2 ...

[sagetrac-cwitty]

Work Issues: #9580

[sagetrac-cwitty]

comment:5

Doctests and selenium tests passed for me, using Firefox (well, Iceweasel) 3.6.4. (Except for test_7434, which failed with both sagenb 0.8.1 and 0.8.2, presumably because I don't have Java set up on this machine.)

This will be a positive review once you fix #9580 :)

[sagetrac-cwitty]

comment:6

Actually, I found a bug: the "source editor" feature (#9512) converts line endings from Unix to DOS (so once you've edited the file, mercurial thinks every line has changed).

Given the total non-discoverability of #9512, I'm not sure this bug is worth holding up the new spkg; I'll let somebody else decide that.

[qed777]

Reviewer: Carl Witty

[qed777]

Changed work issues from #9580 to none

[qed777]

comment:7

In order to have a new SageNB package ready for 4.5.2, I've decided to change #9512's status to needs_work and "unmerge" it from SageNB 0.8.2. I've included #3342, #9554, and #9580 in an updated SageNB 0.8.2, which is available at the link in the description.

Note: I haven't added a patch level (e.g., sagenb-0.8.2p0.spkg), but I have renamed the previous version to sagenb-0.8.2-9572.spkg.

[sagetrac-cwitty]

comment:8

Doctests and selenium tests passed (except, again, for test_7434).

Positive review.

[dandrake]

Merged: sage-4.5.2.alpha1

[qed777]

comment:10

Belated note for the release manager: Please merge #3342's sage repository patch with SageNB 0.8.2.

(I should have followed our own advice!)

[qed777]

comment:11

Replying to @qed777:

Belated note for the release manager: Please merge #3342's sage repository patch with SageNB 0.8.2.

But if it's too late for 4.5.2.alpha1, we could, I think, just include the patch in 4.5.2.rc0.

[dandrake]

comment:12

Replying to @qed777:

Belated note for the release manager: Please merge #3342's sage repository patch with SageNB 0.8.2.

(I should have followed our own advice!)

Yes, you should have. :) You're lucky though, I managed to sneak it into alpha1.