Raise an exception when arguments to add_constraint are not admissible

[nathanncohen]

Because of the error reported on :

http://groups.google.com/group/sage-support/browse_thread/thread/b953192f3554337f

It may be good to save an user several hours of trouble because a wrong argument is silently accepted.

Done in this patch ! :-)

Nathann

Component: numerical

Author: Nathann Cohen

Reviewer: Harald Schilly

Merged: sage-4.5.2.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/9579

[haraldschilly]

comment:2

I don't know if testing with RR is the best way to do this, but should work. What's missing is a test for max b/c you only tested for min.

[haraldschilly]

test both arguments, not only one of them

[nathanncohen]

comment:3

Attachment: trac_9579_review.patch.gz

Replying to @haraldschilly:

I don't know if testing with RR is the best way to do this, but should work. What's missing is a test for max b/c you only tested for min.

You do not begin to know how I HATE this RR... Is there any way to check whether a value is numerical without having to import RINGS ? :-D

Even a Python method is fine !!! The most esoteric thing that could be found there is a rational number !

Nathann

[nathanncohen]

comment:4

Attachment: trac_9579.patch.gz

I just updated my patch so that instead of ugly "try/except", a "if" is enough, thanks to Harald's suggestion. By the way, your patch still applies on top of mine, so if you are ok with these changes, let's say this ticket is positively reviewed :-)

Nathann

[haraldschilly]

comment:5

there is still this hurdle to run all tests, i'll start them right now.

[haraldschilly]

Reviewer: Harald Schilly

[haraldschilly]

Author: Nathan Cohen

[haraldschilly]

comment:6

dear release manager, first merge trac_9579.patch and then trac_9579_review.patch

[dandrake]

comment:7

Replying to @haraldschilly:

dear release manager, first merge trac_9579.patch and then trac_9579_review.patch

Merged in 4.5.2.alpha1.

[dandrake]

Merged: sage-4.5.2.alpha1

[qed777]

Changed author from Nathan Cohen to Nathann Cohen

[nathanncohen]

comment:9

My 'n' !! I hadn't noticed it !! Thank you :-)

Nathann