Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "signless" option to laplacian #9707

Closed
jasongrout opened this issue Aug 8, 2010 · 11 comments
Closed

Add a "signless" option to laplacian #9707

jasongrout opened this issue Aug 8, 2010 · 11 comments

Comments

@jasongrout
Copy link
Member

We should have an option to g.laplacian() to return the signless Laplacian, which is attracting attention these days, and which is calculated by D+A instead of D-A (see p. 12 of http://www.doiserbia.nb.rs/ft.aspx?id=0350-13020795011C, for example).

Thanks to Steve Butler for the feature request.

CC: @nathanncohen @rlmill @dcoudert

Component: graph theory

Author: Rajat Mittal

Branch/Commit: e2b64c6

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/9707

@jasongrout jasongrout added this to the sage-5.11 milestone Aug 8, 2010
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@rajat1433
Copy link
Mannequin

rajat1433 mannequin commented Mar 12, 2019

comment:5

Signless laplacian is indeed gaining popularity as evident in the papers below.
So can I add the option to the current Laplacian Matrix method to return signless laplacian matrix?

https://arxiv.org/pdf/1803.06135.pdf

http://elib.mi.sanu.ac.rs/files/journals/publ/101/n095p011.pdf

https://ac.els-cdn.com/S0024379507000316/1-s2.0-S0024379507000316-main.pdf?_tid=59a3915e-dd7a-4dea-87a7-1892bc82cdca&acdnat=1552416165_1a56db5226e8357d8b7c9879a5dc3973

@dcoudert
Copy link
Contributor

comment:6

A quick search effectively returns a significant number of recent publications.

@rajat1433
Copy link
Mannequin

rajat1433 mannequin commented Mar 13, 2019

Reviewer: dcoudert

@rajat1433
Copy link
Mannequin

rajat1433 mannequin commented Mar 13, 2019

Author: Rajat Mittal

@rajat1433
Copy link
Mannequin

rajat1433 mannequin commented Mar 13, 2019

@rajat1433 rajat1433 mannequin assigned rajat1433 and unassigned jasongrout, nathanncohen and rlmill Mar 13, 2019
@rajat1433 rajat1433 mannequin modified the milestones: sage-6.4, sage-8.7 Mar 13, 2019
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 13, 2019

Commit: e2b64c6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 13, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

e2b64c6added signless option

@rajat1433 rajat1433 mannequin added the s: needs review label Mar 13, 2019
@rajat1433
Copy link
Mannequin

rajat1433 mannequin commented Mar 13, 2019

comment:10

Do i need to include this ticket number somewhere in the code?

@dcoudert
Copy link
Contributor

comment:11

We usually add ticket number when we fix a bug. So it's not needed here.

LGTM.

@dcoudert
Copy link
Contributor

Changed reviewer from dcoudert to David Coudert

@vbraun
Copy link
Member

vbraun commented Mar 14, 2019

Changed branch from u/gh-rajat1433/9707_signless_laplacian to e2b64c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants