New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cliquer - Update Upstream contact #9766
Comments
comment:2
SPKG.txt does not list the change you made - instead it lists
It seems you have just copied the previous entry and incremented the patch level. You need to put your own name and date, along with the change you made - but I think you know that. Also the commit message does not have the trac number in it. You should take the opportunity to add the sections from SPKG.txt which are missing - namely:
See It wont take you long to find out the dependcies, and if there are no special build instructions, just put
Dave |
comment:3
Stupid copy/paste mistake... I was even doubting adding a line to the changelog in this case was necessary Sorryyyyy ! (SPKG updated) Nathann |
comment:4
That looks a bit better, but I would suggest a few changes.
I noticed there was no spkg-check file to run the self-tests, which the package does have. That needs addressing, but on another ticket, as it's quite separate. I created a ticket for that (#9767) and will address that at some point myself, if nobody beats me to it. As such, it might be wise to put a note of this fact - one suggestion is below.
Once that is done, I expect to be able to give it a positive review. Dave |
comment:5
Nathann, Dave |
comment:6
I have not had a "stable" internet connection for several weeks now (travelling -- I access internet through coffes, and when I am lucky in the hotels I stay in if they have a connection), and I will not be able to update this spkg until at least one week and a half. Sorry for that. On the technical side David, we have known for a long time that we view development very differently. I try not to forget that you want Sage to be a "professionnal" software, with all the necessary -- what I call -- administration (standard procedures for modification of the code, correct documentation, supporting many platforms, changelogs, etc...). Even though it very often seems "too much" for my way of doing, I have two things to admit :
In the end, even though I have a different way to work, it sounds like we are both trying to work on the same piece of (great) software, as efficiently as we can. This is why I am asking this question to a fellow developper : There are necessary things in all this administration, to ensure that everything stays correct (doctests, spkg-checks, ...), or documented, or logged. But don't you think somethings goes really wrong when it takes 2 weeks, 2 persons, and 30 minutes or 1 hour of cumulated worktime to add an url to a file ? How do you think we could simplify these things ? I am confident any mean you could name would never harm Sage's reliability. I promise you will have this spkg updated with the modifications you requested as soon as I have a -- real -- internet connection. I may even be able to find a way to send it tomorrow ! :-) Nathann |
comment:7
Wonderful airport with a free wifi, and no filter on port 80... Packages updated ! I hope you will like this version Nathann |
comment:8
Replying to @nathanncohen:
Sorry to hear that. I often lose mine from home, and it really annoying. Particularly if I have a chess game scheduled as part of a team. Failure to play lets the whole team down, so I have on several occasions made a 90 mile round-trip to go to my fathers, use his internet, then come home. There's not even a local internet cafe here.
Yes.
I think if Sage is ever going to be a viable alternative to the commercial products, it needs to get more professional in its approach. As Tim Daily points out in that recent thread on sage-devel, if things are not documented properly, then whole sections of code may need to be swapped out as they are unmaintainable. This is very close to the case with SYMPOW.
Yes, I do. It is a waste of peoples time.
I believe I have spoke to you about the cost of fixing bugs. Basically, the earlier a bug is caught, the less expensive it it to fix. In the case of Sage, we are primarily talking about peoples time. Had the documentation error been picked up early, a lot less of peoples time would have been wasted. That's why I've tried to get over to you the point that you should spend you time stopping the bugs in the first place, as it's less time consuming to do that, than it is to fix bugs when they are reported. Dave |
comment:9
Replying to @nathanncohen:
Yes, that looks fine. You should have put the patch on the trac server, but I will do that for you. I'm giving it positive review. As a matter of interest, are you aware of any reason the package should not be updated to the latest, which is 1.2.1? If not, I'll update the package version at the same time as adding the test code to #9767. Dave |
comment:10
Thanks ! But why do you want a patch to be independently uploaded when it is contained in the spkg file ?
Yes. The reason is that I ignored a new version had been released, and that no one beside me was expected to pay attention to this. It's past time I sent an email to the original developpers though, they may not even know their software is used in Sage. I will also ask them to drop me a line when they update their code if they happen to think of it :-) Nathann |
comment:11
Replying to @nathanncohen:
It is how ever other .spkg gets updated. The patch is kept on the trac server. It makes it much easier for a review to see what he is reviewing, and for anyone else to look back and see the changes which were made on the ticket.
I'll update the package then. There needs to be a Solaris specific change too, as the libraries are not being created optimally on Solaris. Dave |
Attachment: 9766.patch.gz Mercurial patch to add contact information and generally clean up SPKG.txt |
Reviewer: David Kirkby |
Author: Nathann Cohen |
comment:13
Since we build Cliquer in Sage with make instead of with SCons (see #9804), should we include SCons in the dependency list in |
comment:14
Replying to @qed777:
No, we should not. I'll create a new patch and provide a new package in a minute. It wont take me long to delete one line.
I don't know where you would add a note that SCons is not a Cliquer dependency. Where would you propose to add such a note? |
comment:16
Perhaps under "Special Update/Build Instructions" or in the relevant "Changelog" note? |
comment:17
I've put a package which removes the SCons from SPKG.txt. I also thought it wise to set the dependency to "None", since that's what used on every other package I've seen, though strictly "Base" is more accurate, I think it's also more confusing. http://boxen.math.washington.edu/home/kirkby/patches/cliquer-1.2.p6.spkg I'm considering this a reviewer patch, so are just going to mark it positive again. Dave |
comment:18
Replying to @qed777:
I'm not sure how best to do this. It would seem sensible that it was documented under the particular version where the dependency was removed, but I don't know how to find that out. I wonder if this package ever had such a dependancy? The upstream source code does not. Nathann created the package, and I don't think he knows anything about SCons, so I doubt he would have used it. You know mercurial better than me - perhaps you can see if there's a record of SCons being removed. Dave |
comment:20
It looks like there was a SConstript file at one point in time:
Now how do I find it when it was removed? Dave |
Attachment: 9766-improved-SPKG.txt-information.patch.gz Improve the historical accuracy of SPKG.txt |
Changed author from Nathann Cohen to Nathann Cohen, David Kirkby |
comment:21
I found out that the call to 'scons' was removed in change set 4 by Minh. I've added that information to that entry. I've marked it as needing review again - perhaps you can look over it Mitesh. Dave |
comment:22
The package with the changes can be found at http://boxen.math.washington.edu/home/kirkby/patches/cliquer-1.2.p6.spkg Dave |
comment:23
Positive review, except for a stray file with the name " cliquer-1.2.p6$ hg stat
? , Could you remove the file? |
comment:24
Replying to @qed777:
Sure. I don't know how that got there. It has a date in 2032 too - only 22 years ahead in time.
I've uploaded the new .spkg, without the file with a comma in its name. Dave |
comment:25
I see the 2032 was the size of the file, not the date! I must have created it myself somehow. Anyway, it has gone now. |
comment:26
Thanks! |
Changed reviewer from David Kirkby to David Kirkby, Mitesh Patel |
This comment has been minimized.
This comment has been minimized.
Merged: sage-4.5.3.rc0 |
comment:29
Replying to @sagetrac-drkirkby:
I think it's worth adding a note (in parentheses) to the Dependencies section that some package['s ordinary build] does not depend on Typical candidates for Also, some packages only do not depend on some others (e.g. libraries) in Sage just because of the way we configure, patch or build / install them. IMHO as well worth a note. |
The URL was missing from the SPKG.txt file, and CJ Fearnley requested it to be changed to work on a debian package of Sage.
Package at
http://boxen.math.washington.edu/home/kirkby/patches/cliquer-1.2.p6.spkg
Component: packages: standard
Author: Nathann Cohen, David Kirkby
Reviewer: David Kirkby, Mitesh Patel
Merged: sage-4.5.3.rc0
Issue created by migration from https://trac.sagemath.org/ticket/9766
The text was updated successfully, but these errors were encountered: