Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up some methods for quasimodular forms ring elements #35004

Merged

Conversation

DavidAyotte
Copy link
Member

Fixes #34778

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Base: 88.59% // Head: 88.59% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (19195b2) compared to base (6a4667b).
Patch coverage: 96.42% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35004      +/-   ##
===========================================
- Coverage    88.59%   88.59%   -0.01%     
===========================================
  Files         2136     2136              
  Lines       396141   396162      +21     
===========================================
- Hits        350977   350970       -7     
- Misses       45164    45192      +28     
Impacted Files Coverage Δ
src/sage/modular/quasimodform/element.py 99.13% <96.42%> (-0.87%) ⬇️
src/sage/categories/super_modules_with_basis.py 96.29% <0.00%> (-3.71%) ⬇️
...rc/sage/categories/super_lie_conformal_algebras.py 95.00% <0.00%> (-1.67%) ⬇️
...e/combinat/cluster_algebra_quiver/mutation_type.py 51.30% <0.00%> (-1.55%) ⬇️
src/sage/doctest/forker.py 80.24% <0.00%> (-1.48%) ⬇️
src/sage/modular/hecke/algebra.py 94.65% <0.00%> (-1.07%) ⬇️
src/sage/graphs/generators/random.py 91.26% <0.00%> (-0.86%) ⬇️
src/sage/cpython/_py2_random.py 75.20% <0.00%> (-0.83%) ⬇️
src/sage/categories/weyl_groups.py 96.47% <0.00%> (-0.59%) ⬇️
src/sage/sets/integer_range.py 91.41% <0.00%> (-0.51%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DavidAyotte
Copy link
Member Author

@videlec you already reviewed this ticket (and put it to positive review), but there was a merging error. It is now fixed.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it was previously positively reviewed.

@vbraun vbraun merged commit 0f0a0d4 into sagemath:develop Feb 24, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up some methods for quasimodular forms ring elements
7 participants